Giter VIP home page Giter VIP logo

Comments (8)

swade1987 avatar swade1987 commented on August 15, 2024 1

I wouldn't expect it to try create a secret in the same namespace as the seed.

I would expect to create a secret with a given name and then have that replicated to all new namespaces.

from registry-creds.

alexellis avatar alexellis commented on August 15, 2024

Why do you want that behaviour?

from registry-creds.

przemolb avatar przemolb commented on August 15, 2024

To keep the secrets' names consistent across namespaces.
Let me turn around the question: what is the technical reason to add registrycreds suffix to each secret ?

from registry-creds.

alexellis avatar alexellis commented on August 15, 2024

I'm open to hearing why this is necessary.

Can you fill out the whole issue template this time?

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

**Describe all possible solutions, and which you suggest**
A clear and concise description of what you want to happen.


**Describe alternatives and workarounds that you've considered**
A clear and concise description of any alternative solutions or features you've considered.


**Additional context**
Add any other context or screenshots about the feature request here.

from registry-creds.

swade1987 avatar swade1987 commented on August 15, 2024

I agree here with @przemolb we have a secret called harbor-image-pull-secret and then the secret that appears in each namespace is harbor-image-pull-secret-creds.

I had to end up explaining to the development team why they should be using harbor-image-pull-secret-creds as they found it misleading.

I think the easiest way to do this is for registry-creds to simply bootstrap the other namespaces with the same secret name as the CRD references for consistency.

from registry-creds.

alexellis avatar alexellis commented on August 15, 2024

@swade1987 without a prefix, you could not have the image pull secret in the same namespace as the seed.

So let's say you had a seed called registry-creds in default. How are you going to then have the controller manage that namespace? It cannot create the managed secret because it would already exist, in an unmanaged state. I'm open to suggestions.

from registry-creds.

argais avatar argais commented on August 15, 2024

Came here for this exact issue.
When thinking of replicating a secret across namespaces what comes to mind is copy the source everywhere else as is.

In a greenfield environment it would be totally fine to have an enforced suffix, but when you are trying to substitute a brute force (read copy it over on ci or whatever to a new ns) instead, then you can't have that suffix. Having the enforced suffix in this case would require updating a couple hundred manifests to use the different secret name instead of just replacing the old one.

from registry-creds.

alexellis avatar alexellis commented on August 15, 2024

/lock: inactive, raise your own issue as a GitHub Sponsor

from registry-creds.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.