mergeFrom doesn't merge fields from other object about protobuf-swift HOT 6 CLOSED

If other is the default instance, we know none of its fields are set so we can skip the merge. This is small optimization.

from protobuf-swift.

you can see above that its not merging the contents from the other protobuf because a populated protobuf is always equal to the default instance.

i removed the return statement in mergeFrom and it works properly.

from protobuf-swift.

You are trying to merge two of the same objects other, this is not true.
In this case, the other object hasn't established fields.
You can merge other and user, because user has established field.
You can look implementation in C ++ / Java.

from protobuf-swift.

sorry, i had a typo in there. this shows that other and user don't merge properly:

from protobuf-swift.

because user == UserService.Containers.user() they don't merge.

from protobuf-swift.

message Test
{
  optional string str = 11;
}

        var builder = Test.builder()
        builder.str = "123"
        println(builder)
        var build = builder.build()
        println(build)
        var builder2 = Test.builder()
        builder2.mergeFrom(build)
        var build2 = builder2.build()

        println(build2)
        println(build2 == build)
        println(build2 == Test.builder().build())
        println(build == Test.builder().build())
        println(build == Test())

Log:

 str: 123 

 str: 123 

 str: 123 

 str: 123 

true
false
false
false

All ok!!

from protobuf-swift.