Giter VIP home page Giter VIP logo

Comments (4)

alexforster avatar alexforster commented on June 14, 2024

Interesting. It's certainly not necessary, but I do like having some sort of sanity check that says "I'm connected to something that looks like an Asterisk server".

Does this emulator emit one line followed by \r\n?

from amiclient.

geext-dk avatar geext-dk commented on June 14, 2024

Yes. Without the part that throws the exception your library works flawlessly. The library still reads the first line, but instead just ignores it.
I think it's responsibility of a developer, not library, to connect to the correct server. If the library connects to the wrong server, it won't work anyway. If it connects to the server that tries to mimic AMI for bad purposes, it isn't hard for the server to send correct handshake message, so there isn't much point as far as I know.

from amiclient.

alexforster avatar alexforster commented on June 14, 2024

Yeah this isn't a problem. I need to check that the server emits something so that this check keeps working, but I don't think it's necessary to check for the correct verbiage. I'll just check that I successfully read a non-empty line. I'll cut a new release tonight or tomorrow.

from amiclient.

geext-dk avatar geext-dk commented on June 14, 2024

Thank you very much.

from amiclient.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.