The module name to include is "the-cormoran.loaderscss" and not "the-cormoran.angular-

<a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Wrong module name about angular-loaders HOT 5 CLOSED

alexjoffroy commented on June 1, 2024

Wrong module name

from angular-loaders.

Comments (5)

alexjoffroy commented on June 1, 2024 1

241db89 fixes the bug.

Please refer to README.md for new installation and use instructions.

from angular-loaders.

PriyanshDwivedi commented on June 1, 2024

@marchrius It is giving me errors for both the module names.

from angular-loaders.

alexjoffroy commented on June 1, 2024

@marchrius @PriyanshDwivedi

I do not use this package anymore, but I just try it in a CodePen.

The minified version does not work and I get an error in my console.

But the not-minified script works well. You can see the CodePen here:
https://codepen.io/cormoran/pen/qakWky

I will try to fix and update the package ASAP.

from angular-loaders.

mpint commented on June 1, 2024

thanks for breaking my project by hardcoding your username into the module. classy...

from angular-loaders.

alexjoffroy commented on June 1, 2024

Even if I do not appreciate this kind of whiny comments, here are some explanations.

The project needed some structure improvements, and had not yet been released. And as my github nickname changed since the start of this project, I updated it in the module to be more consistent.

So, yes, this (first) release breaks existing projects using angular-loaders. The next bugfixes/evolutions will be shipped in new releases, so this case should not arrive anymore.

from angular-loaders.

Recommend Projects