Giter VIP home page Giter VIP logo

Comments (12)

KorySchneider avatar KorySchneider commented on August 18, 2024 2

Same issue here, started when I upgraded to 7.1.0. I tried reverting the change in 11096b5 and it is indeed the culprit.

Those affected must either downgrade to 7.0.1 until this is fixed, or implement quite a bit of logic to prevent this from happening. @alexkatz What are your thoughts this situation? I think it would be best if this behavior was optional, but disabled by default.

from react-tiny-popover.

alexkatz avatar alexkatz commented on August 18, 2024 1

Hey @cs-ashiqu,

I made a slight modification to your codesandbox to get it working properly:
https://codesandbox.io/s/intelligent-ride-g1w9q1?file=/src/App.js

I think the onClickOutside is behaving properly in your sandbox. By clicking on the inner popover, you are indeed clicking outside of the outer one, so the outer one closes.

The solution is to nest the inner popover within the outer one, arranging things such that clicking within the inner popover is not actually clicking outside of the outer.

Hope that makes sense!

from react-tiny-popover.

alexkatz avatar alexkatz commented on August 18, 2024 1

Sorry, did not mean to reopen this issue. Closing again, but please feel free to create a new issue if you're still experiencing issues.

from react-tiny-popover.

YuitoSato avatar YuitoSato commented on August 18, 2024

#172

from react-tiny-popover.

YuitoSato avatar YuitoSato commented on August 18, 2024

@KorySchneider @alexkatz
Thank you for your work.
Did this pr solve this issue?

7d62b9ba

from react-tiny-popover.

KorySchneider avatar KorySchneider commented on August 18, 2024

@YuitoSato I will test the new version soon and let you know, thanks!

from react-tiny-popover.

KorySchneider avatar KorySchneider commented on August 18, 2024

@YuitoSato Sorry I thought a new version had been released. The link in your comment is not to a PR.

from react-tiny-popover.

alexkatz avatar alexkatz commented on August 18, 2024

@KorySchneider @YuitoSato

This week I've released 7.2.0, which adds a clickOutsideCapture boolean option, false by default. I'll close this for now, but feel free to create a new issue if you're still experiencing problems in this area.

Cheers!

from react-tiny-popover.

KorySchneider avatar KorySchneider commented on August 18, 2024

@alexkatz Tested and it's working. Many thanks!

from react-tiny-popover.

YuitoSato avatar YuitoSato commented on August 18, 2024

Thank you for your works! @alexkatz

from react-tiny-popover.

cs-ashiqu avatar cs-ashiqu commented on August 18, 2024

Hi @alexkatz @KorySchneider
I also had same issue with nested popovers and was waiting for the new version hoping that would resolve the issue. But I am still facing the same issue with new version too.

Problem: Interacting with nested popover will close the parent popover.
Example: https://codesandbox.io/s/wild-brook-6ttx95?file=/src/App.js

Let me know if I am missing something here in my implementation and it would be great if you could suggest a solution for these kind of use cases.

from react-tiny-popover.

KorySchneider avatar KorySchneider commented on August 18, 2024

@cs-ashiqu I looked at your example and unfortunately am not sure why it isn't working properly 🙁

from react-tiny-popover.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.