Giter VIP home page Giter VIP logo

Comments (10)

alexneo2003 avatar alexneo2003 commented on June 15, 2024 1

Please let me know if this repository is still maintained

yep, it is still maintained)
but unfortunately I don't have enough time for this feature

if I shall do a PR

I'm really will be appreciated for you work

if it should be backward compatible

yes please let it be backwards compatible because many people won't want to upgrade

from playwright-azure-reporter.

Az8th avatar Az8th commented on June 15, 2024 1

Hello, sorry but I don't think I will be able to do such a pull request quickly, I realized the time I need to do it, and I think it would be better used by putting those features in an AzureDevOps or VSCode extension directly, especially since the API seems to give some alternatives that I would like to explore

from playwright-azure-reporter.

alexneo2003 avatar alexneo2003 commented on June 15, 2024 1

@Az8th I got you
Let me write this feature

from playwright-azure-reporter.

Az8th avatar Az8th commented on June 15, 2024

Hi ! Just a remember that keeping test title clean seems to be encouraged since 1.42 update, as tags and annotations can now be added outside of it.
Could the same be applied here ? Without decorators, it could appear like so

test("Title", {
  tag: ['@tag1', '@tag2'],
  annotation: [{ type: 'azureTestPlanID', description: '42' }]
  }, async ({ page }) => {
  //perform actions
});

Please let me know if this repository is still maintained, and if you can envisage to do it by yourself or if I shall do a PR (in this case, I need to know if it should be backward compatible)

from playwright-azure-reporter.

Az8th avatar Az8th commented on June 15, 2024

Just realized that using the same method for test plan/suite ID could also permit to add support for multiple plans, as annotations can also be made in test.describe()
To ensure backwards compatibility, the test plan ID should still be present in the playwright.config.ts and act as a default, that can be overrided when an azureTestPlanID is precised.

Example:

...
annotation: [
  { type: 'azureTestPlanID', description: '1' },
  { type: 'azureTestSuiteID', description: '34' },
  { type: 'azureTestCaseID', description: '42' },
  // { type: 'azureSharedStepID', description: '255' }
]
...

from playwright-azure-reporter.

alexneo2003 avatar alexneo2003 commented on June 15, 2024

@Az8th I had published beta version this this feature, try it

npm i @alex_neo/[email protected]

Also you can read README about version

from playwright-azure-reporter.

Az8th avatar Az8th commented on June 15, 2024

Nice ! Can't at the moment, but will definitely try by tomorrow ;)
I see that you have chosen to use tags over annotations, aren't they exposed ?

from playwright-azure-reporter.

alexneo2003 avatar alexneo2003 commented on June 15, 2024

@Az8th any updates?

from playwright-azure-reporter.

Az8th avatar Az8th commented on June 15, 2024

Tested it in CI for a week, while I encountered no bugs, I think that tags are even worse than titles for ID specifying (titles are somewhat unique, while tags should be used to pack test by categories)
We should definitely go for test annotations here ! I don't know if they are exposed in the Playwright API, I will check this later today !

from playwright-azure-reporter.

Az8th avatar Az8th commented on June 15, 2024

Seems it is : https://playwright.dev/docs/api/class-testcase#test-case-annotations
Can adapt your PR to support annotations instead of tags if you want.
Unless you also want to support tags, but I would suggest to add a "id-mode" parameter that could be either title, tag or annotation to avoid unwanted collisions, which defaults to "title" to maintain backwards compatibility

from playwright-azure-reporter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.