Readme example fails to work about cognito-srp HOT 4 CLOSED

Oh my god - they've migrated back to map[string]string from map[string]*string. I literally just updated the package to better support the pointer maps 😭

I think what's happening in your case is in the conversion from map[string]string to map[string]*string you're referencing a loop scoped variable that has its value changed every iteration:

for k, v := range resp.ChallengeParameters {
    chp[k] = &v
}

should be:

for k, v := range resp.ChallengeParameters {
    scopedV := v
    chp[k] = &scopedV
}

The easiest fix will be to use v2 of this repo, as that uses map[string]string throughout. In your above example just replace github.com/alexrudd/cognito-srp/v3 with github.com/alexrudd/cognito-srp/v2.

I'll release a new version at the weekend so we're back to map[string]string

from cognito-srp.

BTW thanks for the work you do! All the AWS API is so frustrating, and you're trying to make it better to work with ❤️

from cognito-srp.

Thanks alex! So shame I've fallen into this common mistake with iterations.

BTW dont clue a single reason for them to use string pointers instead of strings. Thanks for help again.

from cognito-srp.

Got a chance to fix this. Released v4.0.0 which can be imported using cognitosrp "github.com/alexrudd/cognito-srp/v4"

Thanks for opening the issue :)

from cognito-srp.