Giter VIP home page Giter VIP logo

Comments (4)

alezost avatar alezost commented on August 23, 2024

Thanks for the suggestion, I'll look into these modes soon.

from alect-themes.

alezost avatar alezost commented on August 23, 2024

OK, so I've added support for tuareg, merlin, utop and cperl.

A couple of problems I faced: as my distribution doesn't provide
packages for merlin and utop, I themed the faces of merlin and utop
emacs packages blindly (I beg a pardon, but I didn't bother to compile
those prorgams from source), so if you find that something is blatantly
ugly, please let me now (screenshots are appreciated).

Also I didn't find where caml-types-expr-face,
caml-types-typed-face, caml-types-scope-face, caml-types-def-face
and caml-types-occ-face are used, and unlike merlin/utop I can't even
guess the context.

However there is a real problem with these faces: they can't be
customized
at all (with any theme). As you can see in
caml-types.el,
these faces are not defined in the usual manner via defface, but using
make-face function instead, which leads to the impossibility of being
themed.

For example, you may check M-x customize-face RET caml-types-def-face:
do you see "NO CUSTOMIZATION DATA; not intended to be customized."?
That's not good :-)

By the way, C-h f make-face tells:

Do not call this directly from Lisp code; use `defface' instead.

So someone who is interested should probably contact with the
maintainers of the caml emacs package and report about this problem.

from alect-themes.

 avatar commented on August 23, 2024

I tested and everything looks great! Merlin (and utop) doesn't look ugly at all, specially Merlin's error check which by default used awful colors now displays erros in bold red, much more pleasing and easy to scan.

Don't bother about caml-mode type faces, they're just legacy cruft and, as far as I know, it's only a dependency for Tuareg since there's shared code.

Thank you so much for providing these faces so quickly! Really good job.

from alect-themes.

alezost avatar alezost commented on August 23, 2024

OK, thanks for the feedback! Closing this issue.

from alect-themes.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.