Giter VIP home page Giter VIP logo

Comments (7)

felixdelafuente avatar felixdelafuente commented on August 15, 2024

Hi sir @warengonzaga, I'll work on this.

from homepage.

warengonzaga avatar warengonzaga commented on August 15, 2024

Awesome @felixjeromedelafuente, I'll assign it to you.

from homepage.

warengonzaga avatar warengonzaga commented on August 15, 2024

I can confirm that this issue has been fixed and merged in #11

from homepage.

warengonzaga avatar warengonzaga commented on August 15, 2024

Re-opening the issue, the same issue appears after the deployment to Vercel. Can you take a look into it @felixjeromedelafuente?

from homepage.

felixdelafuente avatar felixdelafuente commented on August 15, 2024

Hi sir @warengonzaga, I inspected the deployed website and also the main and dev branch. It seems that the deployed website uses the main branch while the changes I made in the Navbar were merged on the dev branch because I created a PR for my changes on the dev branch based on the instructions from the ReadMe file.

Navbar.jsx on main branch:
image

Navbar.jsx on dev branch:
image

Should I create a new PR directing it to the main branch instead?

from homepage.

warengonzaga avatar warengonzaga commented on August 15, 2024

I'll compare the changes from the dev to the main branch.

from homepage.

warengonzaga avatar warengonzaga commented on August 15, 2024

Applied the changes to the main branch from the dev.

from homepage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.