Comments (18)
Thanks for the fast answer. We'll investigate with @SiTaggart to come back with a satisfactory answer!
from autocomplete.
I'm on Ubuntu :)
from autocomplete.
That is awesome. Thanks a lot for putting time and energy into it, this is an important step forward both for autocomplete.js, but also for our own education inside the team, and what we'll do on other projects.
from autocomplete.
Thanks for the suggestion. I'd love to have this support as well, but I have no experience in this field and have trouble understanding what the PR is doing.
Could you give me a bit more details about the end result (which attributes to add on which elements) so I can see the best way to add it to the lib?
from autocomplete.
Maybe this sitepoint article on accessible web components (multi-select) can help a bit as well.
from autocomplete.
Thanks. I've read the article and see what I can do about it. Any help greatly appreciated here :)
from autocomplete.
I can help do some testing with Safari & VoiceOver. We also have a blind quality engineer who can help tell us if this is usable.
from autocomplete.
making search on our site virtually unusable for screen reader users.
@kaelig Could you share your website address, so I have a real-world example on which to test?
from autocomplete.
@pixelastic we're going to release search on www.lightningdesignsystem.com very soon. For this first release we're going to hide the search form away from screen readers.
from autocomplete.
I'm working on an Ubuntu machine and tried to install ChromeVox as a Chrome extension, but it just freezes and kill my browser. I'm going to try other screen readers on Ubuntu, but any suggestion on which one I should use are welcome.
Edit: Nevermind, it was because I was using Chromium. Works well with Chrome and ChromeVox, I'm seeing a few issues already.
from autocomplete.
I pushed a branch with part of the improvement of the PR on typeahead here : https://github.com/algolia/autocomplete.js/tree/fix/voice
I have only added basic roles (combobox/listbox), setting the aria-expanded
based on the dropdown visibility and linking the aria-activedescendant
to the id of the actual selected suggestion.
I'll now have to add the support for reading the hint, but I wanted to push that first to let you test it.
@redox: I failed to understand how to test the features I was adding, so I wrote down in pseudo-code the tests to write in TOTEST.txt
. I'd like a few pointers on how to test that the correct attributes are set on the various elements, at startup, when typing and when selecting a suggestion. Not sure if it goes in unit or integration testing.
from autocomplete.
Hey team, I was also asked about ARIA support which is a requirement for all government domains.
Do we have an ETA of where we are actually and what we should do here? Is someone working on this?
from autocomplete.
Any updates on this?
Maybe I can help. Let me know, and I'll ask my manager to allow me to spend a few days on making it accessible.
from autocomplete.
@kaelig I bet this would be appreciated, since this ticket has a label "help wanted" and "pull request welcomed" attached (though I think you want official confirmation before starting, since you likely are already aware of the labels).
from autocomplete.
@kaelig help is definitely welcome if this is something you can provide :) I'll be happy to merge any PR 👍
from autocomplete.
@kaelig Help would be more than welcome. I started something on https://github.com/algolia/autocomplete.js/tree/fix/voice where I integrated most of the fixes mentionned in the linked blog post. I have not really tested it as I have no screen reader available, though. And the commit is a bit late in the history now, but it should give you a great starting point.
Let us know if you need anything else. It has been some time since I worked on that but I might still help if needed.
from autocomplete.
@pixelastic That's awesome! If you are on Windows 10 or macOS you have access to a screen reader by default in the OS. If you're a Linux user it's a bit more complicated.
Let me ask my manager, I'll get back to you about this.
from autocomplete.
For those who haven't followed - autocomplete.js is now accessible to screen reader users!
from autocomplete.
Related Issues (20)
- `id` setting should apply to the form element too
- Set search input height in Parcel bundler. HOT 4
- Plugins createAutocomplete HOT 4
- onSelect() called after getSources(), causing a closing delay of the dropdown
- Sending events in the render function
- aria-labelledby on the input element fails WCAG checks because the target button has no text
- Detached mode - entered text is present in two places HOT 1
- Korean text disappears from the input box. HOT 10
- In detached mode when there are no items, the dropdown still appears HOT 4
- VUE Autocomplete return instead of JSX from a VUE Component HOT 1
- Autocomplete box doesn't work with fixed positioning
- Autocomplete returning empty result HOT 1
- onSelect item should trigger store.pendingRequests.cancelAll(); HOT 1
- `yarn add @algolia/autocomplete-js` produces a bunch of unmet peer dependency warnings HOT 2
- Migration from 0 to v1 is about to end my reliance on this control HOT 1
- Autocomplete panel not close on clicking outside in react 18 HOT 3
- "insight:true" shows error in createAutocomplete with NextJS React18 HOT 2
- Issue in Autocomplete inside custom element (web component) using React instant search
- Autocomplete Plugin: createQuerySuggestionsPlugin no support in React 18.
- TypeError: Cannot read properties of null (onKeyDown.js) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from autocomplete.