Giter VIP home page Giter VIP logo

Comments (5)

ElPicador avatar ElPicador commented on May 25, 2024

Adding "stop_urls": [ "https://docs.barricade.io/../" ], fixes the issue

from docsearch-scraper.

pixelastic avatar pixelastic commented on May 25, 2024

@ElPicador Do you think we can close the issue?

from docsearch-scraper.

ElPicador avatar ElPicador commented on May 25, 2024

The bug is still there. But we have a work-around.
If we want to open source it, it should be fixed. If not, we do not really care 😄

from docsearch-scraper.

pixelastic avatar pixelastic commented on May 25, 2024

OK, let's keep the issue open then.

But if we want to consider it fixed, it needs to have a test passing, proving that it is indeed fixed. And I am still unsure how we could test that. I'm not sure we could plugin some unit tests on that. Maybe we'll have to go full integration testing by serving a local website and running the crawler on it.

from docsearch-scraper.

maxiloc avatar maxiloc commented on May 25, 2024

@pixelastic Do we let that one open ? I think we should recreate one for integration testing

from docsearch-scraper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.