Giter VIP home page Giter VIP logo

Comments (15)

Haroenv avatar Haroenv commented on May 23, 2024 1

Thanks for your interest, indeed what's missing to move this from beta ➡️ full release is the following:

  1. more expanded documentation
  2. proper testing strategy
  3. atomic indexing (#5)
  4. indexing only changed objects

For now I didn't have the time yet to squash these bugs, but it definitely works, tested in a few different sites so far.

So a time frame isn't there yet, but I'll make sure to make some time for this when I'm out of holiday and can dedicate some time on this.

Is there anything else you would like to see @janosh?

from gatsby-plugin-algolia.

janosh avatar janosh commented on May 23, 2024 1

@Haroenv I'm struggling to get indexing to work in this repo. I'm trying to index all pages sourced from Contentful, but no records are added to the index I created with my Algolia account. Instead, running gatsby build I receive the error that data is undefined in gatsby-plugin-algolia's transformer on line 27 of gatsby-config.js.

Could you perhaps take a look at this?

from gatsby-plugin-algolia.

ErisDS avatar ErisDS commented on May 23, 2024 1

I'm having the exact same issue:

Cannot read property 'allSitePage' of undefined

I'm using the exact code from the readme, it errors in the transformer because no data is passed to the function.

The same query works perfectly in the graphql query explorer.

I'm using Gatsby v2 and trying to figure out if there's something that needs migrating?

from gatsby-plugin-algolia.

ErisDS avatar ErisDS commented on May 23, 2024 1

@Haroenv I will try, what I can do for now is point you at my branch / commit:

TryGhost/docs@bee7021

Hopefully that at least shows that my code is near-identical to the readme.

The outcome on gatsby build is:

image

from gatsby-plugin-algolia.

janosh avatar janosh commented on May 23, 2024 1

@Haroenv Were you able to reproduce (or even fix) the error in my repo?

from gatsby-plugin-algolia.

ErisDS avatar ErisDS commented on May 23, 2024 1

@Haroenv Thank you for taking the time to do that 🎉

from gatsby-plugin-algolia.

janosh avatar janosh commented on May 23, 2024

@Haroenv Any news yet?

from gatsby-plugin-algolia.

Haroenv avatar Haroenv commented on May 23, 2024

Atomic indexing has been done, although I'm still going to do a second pass at another time to use less indexing operations. (indexing only the changes). As well as needing proper tests.

Is there anything you specifically need before using this?

from gatsby-plugin-algolia.

Haroenv avatar Haroenv commented on May 23, 2024

I'll take a look at that yes :)

from gatsby-plugin-algolia.

Haroenv avatar Haroenv commented on May 23, 2024

@ErisDS would it be possible to create a minimal example? you can start from the one in the repository :)

from gatsby-plugin-algolia.

Haroenv avatar Haroenv commented on May 23, 2024

So far I've managed to get your site to build and see that index to Algolia seems not to end, but I don't get that error :(

from gatsby-plugin-algolia.

Haroenv avatar Haroenv commented on May 23, 2024

Weird to be happy to finally have an error, but I'm happy that I now can start debugging

from gatsby-plugin-algolia.

Haroenv avatar Haroenv commented on May 23, 2024

I found the issue (and also a source of grey hairs maybe?) TryGhost/docs#7 and sbsev/gatsby-site#40

from gatsby-plugin-algolia.

Haroenv avatar Haroenv commented on May 23, 2024

@janosh, I actually saw you made the same kind of “mistake” so I didn’t have to try it out. I’m concinced my pr there was necessary and the fix though :)

from gatsby-plugin-algolia.

Haroenv avatar Haroenv commented on May 23, 2024

oops, this shouldn't really have closed this issue since it was mixed with the "timeframe out of beta", but I answered that :). As @ErisDS said, I might change the way of passing the query to a more standard way if that makes sense

from gatsby-plugin-algolia.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.