Comments (10)
@LukyVj could we ensure the active
state track the scroll? It's confusing to have a fixed sidebar but only the original link being active.
from places.
@redox You mean like a scrollSpy on the documentation / examples ?
If so, we discussed about it some time ago with @vvo and @aplu and we agreed on not using it.
We can still give it a try!
from places.
@redox You mean like a scrollSpy on the documentation / examples ?
Yes
If so, we discussed about it some time ago with @vvo and @aplu and we agreed on not using it.
I'm fine not using it (even if I think we should) but then we should not highlight the active link because it's confusing when you scroll.
from places.
Sorry I pushed for us not to have the "scroll spy" feature because it's never really accurate and more a cool effect rather than a real useful navigation helper (in my opinion).
Still the current behavior (click, set active) is useful even if it does not tracks because it represents the last thing you clicked?
from places.
Here, I don't even know what was the last thing I clicked and the currently highlited section is not the one I am looking at (=== fancy in my mind :D)
from places.
(updated screenshot)
from places.
The scroll spy feature on bootstrap is definitely broken :)
I'm fine not implementing the scroll spy thing but what about removing the active
class on scroll then? I think it's super confusing to keep highlighting an entry of the menu while scrolling down -> users will think about a "broken scroll spy" not about "the last link I clicked".
from places.
Yes removing it when scrolling is fine for me
from places.
Not sure it's even broken on getBootstrap, the thing is that those scroll spy are making assumptions that the top text is the currently readen one, it might or might not be (+ crazy margin/paddings etc.. to take into account)
from places.
This has been fixed with the new scrollspy.
from places.
Related Issues (20)
- Autocomplete doesn't work in input container
- Error on typings.d.ts HOT 1
- The default search config doesn't suggest country or state results
- Geolocation differences between two similar API calls HOT 3
- Addresses in Australia are not working
- Search by zipcode partially working in Canada HOT 1
- Storing the results
- Brave browser seems not supported HOT 1
- "Uncaught ReferenceError: the process is not defined" - VANILLA JS HOT 3
- District instead of City in search results
- How to get appID and api key HOT 1
- Multiple language address returned. HOT 2
- French region ยซ Grand Est ยป mispelled
- Dependency Dashboard
- Projects with low Build Activity - Survey
- FYI: Places.js API Cities Polyfill HOT 2
- PlacesAPI: A UK-only Places alternative, built on Algolia, for super easy migration HOT 1
- can I host my own version of algolia places ? HOT 3
- Redirect needed
- Error in AlgoliaSearchCore.js HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from places.