Giter VIP home page Giter VIP logo

Comments (10)

redox avatar redox commented on August 22, 2024

@LukyVj could we ensure the active state track the scroll? It's confusing to have a fixed sidebar but only the original link being active.

from places.

LukyVj avatar LukyVj commented on August 22, 2024

@redox You mean like a scrollSpy on the documentation / examples ?
If so, we discussed about it some time ago with @vvo and @aplu and we agreed on not using it.

We can still give it a try!

from places.

redox avatar redox commented on August 22, 2024

@redox You mean like a scrollSpy on the documentation / examples ?

Yes

If so, we discussed about it some time ago with @vvo and @aplu and we agreed on not using it.

I'm fine not using it (even if I think we should) but then we should not highlight the active link because it's confusing when you scroll.

from places.

vvo avatar vvo commented on August 22, 2024

Sorry I pushed for us not to have the "scroll spy" feature because it's never really accurate and more a cool effect rather than a real useful navigation helper (in my opinion).

Still the current behavior (click, set active) is useful even if it does not tracks because it represents the last thing you clicked?

from places.

vvo avatar vvo commented on August 22, 2024

2016-05-01-223811_1195x399_scrot

Here, I don't even know what was the last thing I clicked and the currently highlited section is not the one I am looking at (=== fancy in my mind :D)

from places.

vvo avatar vvo commented on August 22, 2024

(updated screenshot)

from places.

redox avatar redox commented on August 22, 2024

The scroll spy feature on bootstrap is definitely broken :)

I'm fine not implementing the scroll spy thing but what about removing the active class on scroll then? I think it's super confusing to keep highlighting an entry of the menu while scrolling down -> users will think about a "broken scroll spy" not about "the last link I clicked".

from places.

vvo avatar vvo commented on August 22, 2024

Yes removing it when scrolling is fine for me

from places.

vvo avatar vvo commented on August 22, 2024

Not sure it's even broken on getBootstrap, the thing is that those scroll spy are making assumptions that the top text is the currently readen one, it might or might not be (+ crazy margin/paddings etc.. to take into account)

from places.

redox avatar redox commented on August 22, 2024

This has been fixed with the new scrollspy.

from places.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.