Giter VIP home page Giter VIP logo

Comments (2)

weavermarquez avatar weavermarquez commented on May 29, 2024

I also had a quick look, and this issue also affects [[fortune:arst]] and [[badge:hello]] as expected due to these also having :display 'full in their org-deflink definitions. Whether the issue is in :display or a misconfiguration, I'm not sure.

I just had a quick scan in org-fold-core.el which may have some relevant information. I wonder if the buffer-local variable org-fold-core--specs is relevant at all, since I see it mentioned in the docstring for that file.

org-fold-core--specs...
BEFORE adding a link:

Value in #<buffer example.org>
((org-fold-outline
  (:visible)
  (:ellipsis . "...")
  (:isearch-ignore)
  (:global)
  (:isearch-open . t)
  (:front-sticky . t)
  (:rear-sticky)
  (:fragile . org-fold--reveal-outline-maybe)
  (:alias headline heading outline inlinetask plain-list))
 (org-fold-block
  (:visible)
  (:ellipsis . "...")
  (:isearch-ignore)
  (:global)
  (:isearch-open . t)
  (:front-sticky . t)
  (:rear-sticky)
  (:fragile . org-fold--reveal-drawer-or-block-maybe)
  (:alias block center-block comment-block dynamic-block example-block export-block quote-block special-block src-block verse-block))
 (org-fold-drawer
  (:visible)
  (:ellipsis . "...")
  (:isearch-ignore)
  (:global)
  (:isearch-open . t)
  (:front-sticky . t)
  (:rear-sticky)
  (:fragile . org-fold--reveal-drawer-or-block-maybe)
  (:alias drawer property-drawer))
 (org-link-description
  (:visible . t)
  (:ellipsis)
  (:isearch-ignore)
  (:global t)
  (:isearch-open)
  (:front-sticky)
  (:rear-sticky)
  (:fragile . org-link--reveal-maybe)
  (:alias))
 (org-link
  (:visible)
  (:ellipsis)
  (:isearch-ignore)
  (:global t)
  (:isearch-open . t)
  (:front-sticky)
  (:rear-sticky)
  (:fragile . org-link--reveal-maybe)
  (:alias)))

AFTER typing [[fortune:bluh]]:

Value in #<buffer example.org>
((org-fold-outline
  (:visible)
  (:ellipsis . "...")
  (:isearch-ignore)
  (:global)
  (:isearch-open . t)
  (:front-sticky . t)
  (:rear-sticky)
  (:fragile . org-fold--reveal-outline-maybe)
  (:alias headline heading outline inlinetask plain-list))
 (org-fold-block
  (:visible)
  (:ellipsis . "...")
  (:isearch-ignore)
  (:global)
  (:isearch-open . t)
  (:front-sticky . t)
  (:rear-sticky)
  (:fragile . org-fold--reveal-drawer-or-block-maybe)
  (:alias block center-block comment-block dynamic-block example-block export-block quote-block special-block src-block verse-block))
 (org-fold-drawer
  (:visible)
  (:ellipsis . "...")
  (:isearch-ignore)
  (:global)
  (:isearch-open . t)
  (:front-sticky . t)
  (:rear-sticky)
  (:fragile . org-fold--reveal-drawer-or-block-maybe)
  (:alias drawer property-drawer))
 (org-link-description
  (:visible . t)
  (:ellipsis)
  (:isearch-ignore)
  (:global t)
  (:isearch-open)
  (:front-sticky)
  (:rear-sticky)
  (:fragile . org-link--reveal-maybe)
  (:alias))
 (org-link
  (:visible)
  (:ellipsis)
  (:isearch-ignore)
  (:global t)
  (:isearch-open . t)
  (:front-sticky)
  (:rear-sticky)
  (:fragile . org-link--reveal-maybe)
  (:alias))
 ('full
  (:visible)
  (:ellipsis)
  (:isearch-ignore)
  (:global t)
  (:isearch-open . t)
  (:front-sticky)
  (:rear-sticky)
  (:fragile . org-link--reveal-maybe)
  (:alias)))

from org-special-block-extras.

alhassy avatar alhassy commented on May 29, 2024

Hey @weavermarquez 👋🏽

This is a wonderful package!

I'm glad to hear it 😀

I am hoping to take this and make a nice blog.

That's actually why I made this package to begin with 😅

Whether the issue is in :display or a misconfiguration, I'm not sure.
Wrong type argument: symbolp, 'full

It seems org-deflink assumes a raw name full rather than a quoted name 'full and so adds on the missing quote. However, there was no check for this and so some calls passed in full whereas others passed in 'full ---resulting in ''full which is not a symbol! The fix was to assert :display, for org-deflink, always obtains a symbol and so no need to add on any missing quotes.

@weavermarquez If you have the time, please consider writing a regression test ----sadly I don't have the bandwidth for this right now.

Anyhow, thanks for bringing this up and hope it works well for you going forward 🥳

from org-special-block-extras.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.