Giter VIP home page Giter VIP logo

Comments (5)

spherop avatar spherop commented on September 24, 2024 1

@cwtuan - good question - here's why:

Since the site is in English, and the developers speak English natively, made sense to write a little helper that creates the translations from the English text - and use the defaultMessage mechanism to fallback.

export const t = (stringToTranslate, defaultString = false, options = null) => {
  if (!stringToTranslate) { return null; }
  defaultString = defaultString || stringToTranslate;
  return intl.get(stringToTranslate.split(' ').join('_').toUpperCase(), options).defaultMessage(defaultString);
};

In render we have:

<span className="titleRow">{t('Thank you')}, {this.props.first_name}!</span>
<span className="titleRow">{t('Your booking is confirmed')}!</span>

Thus t('Thank you') becomes intl.get('THANK_YOU').defaultMessage('Thank you')

Therefore, we don't need English versions of these because we fallback on defaultMessage. Since we have a huge amount to translate, saves us from having English versions of most translations. Also, keeps our views readable with the real text vs harder to grok keys.

Hope this all makes some sense... or maybe I am making an odd move here?

from react-intl-universal.

cwtuan avatar cwtuan commented on September 24, 2024

why not just define a key to fix it?

from react-intl-universal.

spherop avatar spherop commented on September 24, 2024

This pr would resolve: #44

from react-intl-universal.

Panoplos avatar Panoplos commented on September 24, 2024

I second this. During development, it is annoying to have so many warnings.

from react-intl-universal.

cwtuan avatar cwtuan commented on September 24, 2024

Fixed v1.11.1.
https://github.com/alibaba/react-intl-universal/releases/tag/1.11.1

from react-intl-universal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.