Giter VIP home page Giter VIP logo

Comments (2)

cwtuan avatar cwtuan commented on June 23, 2024

Fixed in v1.9.2.

https://github.com/alibaba/react-intl-universal/releases/tag/1.9.2

from react-intl-universal.

lsiric avatar lsiric commented on June 23, 2024

Hi @cwtuan, thanks for the fix. Having language local data in multiple files is a great, and a must-have feature for any non-trivial application.

The issue I'm having is with the standard Object.assign function which is used in the load function implementation: it overrides existing defined locales.

Example:

ComponentOne has locales defined in the same folder, in the file localesOne.json:

{
  "en-US": {
    "hello": "hello from component one" 
  }
}

ComponentTwo has locales defined in the same folder, in the file localesTwo.json:

{
  "en-US": {
    "hello": "hello from component two" 
  }
}

load function is used in each of the respective components:

// componentOne
intl.load({
  'en-US': require('localesOne.json');
});
// componentTwo
intl.load({
  'en-US': require('localesTwo.json');
});

The issue occurs when the load function is invoked for the second time, it overrides the entire en-US locale which was already loaded. This means that once the locales for componentTwo are loaded, locales for componentOne are non existent any more (and vice versa).

The solution for this could be using deep merge, thus preserving the old values within the object being extended.

This way the load method could be leveraged in each of the smart components, and managing .json files throughout the application woud be nice and easy.

Is this something that could potentially be implemented?

from react-intl-universal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.