Comments (2)
Fixed in v1.9.2.
https://github.com/alibaba/react-intl-universal/releases/tag/1.9.2
from react-intl-universal.
Hi @cwtuan, thanks for the fix. Having language local data in multiple files is a great, and a must-have feature for any non-trivial application.
The issue I'm having is with the standard Object.assign
function which is used in the load
function implementation: it overrides existing defined locales.
Example:
ComponentOne
has locales defined in the same folder, in the file localesOne.json
:
{
"en-US": {
"hello": "hello from component one"
}
}
ComponentTwo
has locales defined in the same folder, in the file localesTwo.json
:
{
"en-US": {
"hello": "hello from component two"
}
}
load
function is used in each of the respective components:
// componentOne
intl.load({
'en-US': require('localesOne.json');
});
// componentTwo
intl.load({
'en-US': require('localesTwo.json');
});
The issue occurs when the load
function is invoked for the second time, it overrides the entire en-US
locale which was already loaded. This means that once the locales for componentTwo
are loaded, locales for componentOne
are non existent any more (and vice versa).
The solution for this could be using deep merge
, thus preserving the old values within the object being extended.
This way the load
method could be leveraged in each of the smart components, and managing .json
files throughout the application woud be nice and easy.
Is this something that could potentially be implemented?
from react-intl-universal.
Related Issues (20)
- Can the console-polyfill dependency be removed? HOT 1
- Is this project being maintained? HOT 1
- React18 is not supported HOT 2
- Words defined before intl initialization cannot be internationalized HOT 1
- react-intl-universal-extract Error: Cannot find module './extract' HOT 2
- Option to getHTML() without creating outer <span> HOT 1
- Uncaught ReferenceError: global is not defined HOT 2
- [Template] Issue Template
- [Template] Pull Request Template HOT 1
- {days, plural, zero {# يوم} one {# يوم} two {# أيام} few {# أيام} many {# يوم} other {# يوم}} 这种应该怎么写 HOT 1
- 请问最新版本能完全兼容1.3.4版本吗? HOT 1
- getHTML实际返回 React.Element 类型 但是typings 中定义的返回string类型
- intl.getHTML不兼容ts
- Is there any examples with Nextjs HOT 3
- Performance problems of get method HOT 2
- intl type hints
- [object Object] react value HOT 2
- 在使用 react-intl-universal-extract 时遇到 has no default message HOT 1
- The problems in the example
- cache HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-intl-universal.