should variables apply when defaultMessage is used? about react-intl-universal HOT 9 OPEN

Hi, I wrote an example showing my usage, wasn't sure how to provide it, so I forked and added it here in examples folder #10

And there is a branch on that fork, that shows a problem I mentioned in this issue
to reproduce you can,

• switch to that branch, npm i
• npm run extract-intl (that will add an gb.json to locales folder with empty strings as there is no translation yet)
• npm run start
  now when you choose gb as locale, the messages with variables remain as they are in file, despite that we have all it needs to place the variables
  Hope that helps, best of luck!

from react-intl-universal.

Could you show the detail of this case? How do you use defaultMessage method?

from react-intl-universal.

Actually, variables are ignored in the case of using intl.get('something', {foo}).d('something {foo} bar'), so this seems like a bug, as this call results in 'something {foo} bar'. Kind of meaningless to have defaults if this is the case.

from react-intl-universal.

@Panoplos
It should be intl.get('something', {foo}).d(`something ${foo} bar`)

from react-intl-universal.

The documentation doesn't mention this.

from react-intl-universal.

Or rather, it does in the API section, but why is the default variable tag spec different from the locale data?

We have a script that automatically scrapes out defaults to build the base locale, having these be different requires us to remove the $.

from react-intl-universal.

@Panoplos
The defaultMesssage is now ES6 Template literals format. And the locale file is ICU format.

I will make this intl.get('something', {foo}).d('something {foo} bar') work, too, in next release.
Thanks for the suggestion.

from react-intl-universal.

@cwtuan Hi, is there any progress.

from react-intl-universal.

@liuyiliuyi
After reconsideration, I'd like to remain the current behavior for this API, because this proposal may make break changes.

And you could use react-intl-universal-extract
to extract the text in source code to locale files. It will remove the $ automatically.

from react-intl-universal.