Multiple entries in CONTRIBUTORS.md about hacktoberfest HOT 10 CLOSED

@AliceWonderland
If a pull request is merged using a "merge commit" (not squashed into one commit), it will appear in the history as if the creator directly pushed to master.

from hacktoberfest.

Hi Chris, Thanks for notifying me. There's something wrong with the file. There are over 16k lines. Which doesn't seem right.

I will look into this.

In the meantime can we stop merging PRs until I fix this? Thanks!

from hacktoberfest.

Ok, it's not just your entry that's duplicated. My entries are duplicated too.

The first time it happened looks like 3 days ago. Between @robotnamedEmily and @StevenCopeland commits. There's also extra files in the repo that shouldn't be there or are in the wrong folder...

What's confusing too is it looks like many contributors are committing straight into master without creating a PR for review and approval first. I didn't think this was possible unless you're a collaborator. It also looks like some entries may have been overwritten...

If anyone has any suggestions, please let me know. The settings do not allow me to restrict user perms. Only add collaborators and Protect Branches.

from hacktoberfest.

@AliceWonderland Hey Alice, normally, users shouldn't have write access to this repository unless they are collaborators like you mentioned, so this is indeed quite peculiar.

If this issue persists, you might want to contact GitHub support.

from hacktoberfest.

@AliceWonderland I was look at how many contributors there were yesterday(599), and now there are 600. And no PRs have been merged recently!

from hacktoberfest.

@AliceWonderland and @christianheinrichs Duplicate Contributors Formatter solves all your problems

from hacktoberfest.

@shashankKeshava In the related issue #2015 you can see that two people already proposed PRs to programmatically sort the CONTRIBUTORS.md file.

I am not sure when the pull requests #2162 (Artur Aciole), #2163 (Artur Aciole), #2197 (Julius Breckel) and your PR #3002 (Shashank Keshava) are going to be reviewed, but I guess we should all wait for Alice's answer.

from hacktoberfest.

Thanks @christianheinrichs, @kylesferrazza, @shashankKeshava !

As of Nov 17 the CONTRIBUTORS file has been cleaned and up on master.

I created a script to remove dupes before I saw these proposals. Which can still be used. I now have to check out the sort and PRs and also resolve merge conflicts for those PRs before I can merge.

We now have 488 entries instead of 3300. Which doesn't seem quite right given we have 2000+ merges. The bad merges may not only have created dupes but overwritten entries. Hopefully not too many!

I will catch up with what is going on with the sort programs and respond back! Until then please continue to hold off on merges.

Thanks again for all your help and contributions!! :)

from hacktoberfest.

@AliceWonderland Glad you got this worked out! Always happy to help.

from hacktoberfest.

HII can you please assign me this issue.

from hacktoberfest.