Giter VIP home page Giter VIP logo

Comments (9)

LaikaN57 avatar LaikaN57 commented on May 28, 2024

Can you please provide an example of your account number. Like "ZZZZ-####-####" or whatever format yours is?

Mine is an 8 digit number like ######## or /[0-9]{8}/ in regex.

from pyally.

LaikaN57 avatar LaikaN57 commented on May 28, 2024

Ref:

  1. "INT()" at line 283 in ally/Order/order.py (actual line)

from pyally.

LaikaN57 avatar LaikaN57 commented on May 28, 2024

Can you please provide an example of your account number. Like "ZZZZ-####-####" or whatever format yours is?

@mike4kz bump

from pyally.

davidgbiggs avatar davidgbiggs commented on May 28, 2024

Getting same error — my acct number is format #ZZ##### so it broke the int() function

from pyally.

LaikaN57 avatar LaikaN57 commented on May 28, 2024

@davidgbiggs Just wondering, was that account a TradeKing account before Ally bought them or some other odd scenario like a corporate account or something?

from pyally.

davidgbiggs avatar davidgbiggs commented on May 28, 2024

@LaikaN57 No, I just opened the account in the last year.

from pyally.

alanoatwork avatar alanoatwork commented on May 28, 2024

Also have this issue with a newly created account. Is there a fix coming for this?

from pyally.

LaikaN57 avatar LaikaN57 commented on May 28, 2024

@davidgbiggs @alanoatwork Upon first inspection of the API it seems that the API implicitly defines the account number as an integer but I want to double check with the Ally API devs.

@alanoatwork Can you send me your account number format as @davidgbiggs did just so I have another example?

Sent:

MIME-Version: 1.0
Date: Tue, 2 May 2023 07:33:24 -0700
Message-ID: <CALGp1dkf_mVBhBHU5bBs7LZgOr4F6m15ogY0fgiNgiwfnvCPRw@mail.gmail.com>
Subject: Question: Account Number Type
From: Alex Kennedy <[email protected]>
To: Invest API <[email protected]>
Content-Type: multipart/alternative; boundary="000000000000694b1505fab6d2bd"

--000000000000694b1505fab6d2bd
Content-Type: text/plain; charset="UTF-8"

Hello,

We are getting reports that some customers have account numbers with
letters in them, however the API seems to implicitly imply that an account
number is an integer [a]. The format is `#ZZ#####` (more info on this
account here [b]). Upon customer testing, they report that the account
number as a string with letters can be used.

What are valid account number formats? Or at least what character set is
allowed? Any info here would be helpful. Thanks in advance.

PyAlly Github Issue: https://github.com/alienbrett/PyAlly/issues/64

[a]
https://www.ally.com/api/invest/documentation/response-structure/#:~:text=%22account%22%3A%2012345678%2C
[b] https://github.com/alienbrett/PyAlly/issues/64#issuecomment-1031784857

Thank you,
Alex Kennedy

from pyally.

LaikaN57 avatar LaikaN57 commented on May 28, 2024

Looks like we got confirmation on this. I have redacted parts of this conversation for privacy and relevance.

[REDACTED]
From: "Bauchman, Kenneth" <[REDACTED]@invest.ally.com>
To: Alex Kennedy <[email protected]>
Subject: RE: **EXTERNAL** Question: Account Number Type
Date: Tue, 2 May 2023 15:16:45 +0000
Message-ID: <MW5PR16MB4595C9E1C003D9ECDAD8F7DED66F9@MW5PR16MB4595.namprd16.prod.outlook.com>
Content-Type: multipart/mixed; boundary="_004_MW5PR16MB4595C9E1C003D9ECDAD8F7DED66F9MW5PR16MB4595namp_"
MIME-Version: 1.0
[REDACTED]

--_004_MW5PR16MB4595C9E1C003D9ECDAD8F7DED66F9MW5PR16MB4595namp_
Content-Type: multipart/alternative; boundary="_000_MW5PR16MB4595C9E1C003D9ECDAD8F7DED66F9MW5PR16MB4595namp_"

--_000_MW5PR16MB4595C9E1C003D9ECDAD8F7DED66F9MW5PR16MB4595namp_
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable


Thanks Alex,

[REDACTED]

Related to your account number question, account numbers are 8 characters l=
ong. For those account numbers that do contain two letters, they would be f=
ound in the second and third character returned. For example, 2FGxxxxx.

Please let us know if you have any further questions.

Thank you!

ally |  Kenny Bauchman
Production Engineering Manager | Ally Invest
[REDACTED]@invest.ally.com<mailto:[REDACTED]@invest.ally.com>

from pyally.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.