Giter VIP home page Giter VIP logo

Comments (5)

seva100 avatar seva100 commented on June 2, 2024 1

Ah ok, if you use eval_in_train: True in the train config, it'll indeed use the eval mode in train. Basically, turning this option off would enable the normal train mode.
Let me see if it's better to remove this line from our train config example.

from npbg.

seva100 avatar seva100 commented on June 2, 2024

Hi @Shubhendu-Jena, thank you for appreciating our work!
Are you sure that we actually set eval mode to True? As far as I can see, we set the train mode to True before the epoch starts:

npbg/train.py

Line 247 in 355294b

pipeline.model.train()

Or perhaps I'm missing something?

from npbg.

Shubhendu-Jena avatar Shubhendu-Jena commented on June 2, 2024

Hi,

Thanks for the quick response. Actually, it doesn't go to that line as args.eval_in_train evaluates to True in

npbg/train.py

Line 241 in 355294b

if args.eval_in_train or (args.eval_in_train_epoch >= 0 and epoch >= args.eval_in_train_epoch):

This is because in train_example.yaml, we have the following:

eval_in_train: True

from npbg.

Shubhendu-Jena avatar Shubhendu-Jena commented on June 2, 2024

Just to clarify, the numbers reported in the paper are with train mode, right? And have you observed any difference in the evaluation results with train mode vs eval mode?

from npbg.

seva100 avatar seva100 commented on June 2, 2024

I think we only used train mode for the results in the paper; @alievk do you remember by any chance?

from npbg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.