Can you please help me with SDL1.x to SDL2 transition? (palette problems) about openjazz HOT 11 CLOSED

I have updated my code, I was setting the palette on the screen surface instead of the passed surface in Video::restoreSurfacePalette():

https://github.com/vanfanel/openjazz/blob/5d8e106569ee0609500f25a9eff25b9364a999e5/src/io/gfx/video.cpp#L358

But I am still getting wrong colors, now black & while foregrounds with correct backgrounds :(

from openjazz.

Sorry for the late reply, low on free time these days. I like the SDL2 stuff not too invasive, so we can keep compatibility with some older platforms.

The problem with palette conversion I had before is the logical palette (which is grayscale in OJ). We currently need this for some effects to work correctly.
Others have tried this before, but the palette stuff was a blocker:

• https://github.com/Chemrat/openjazz/tree/sdl2
• https://github.com/MaddTheSane/openjazz/tree/sdl2
• https://github.com/sergiou87/openjazz/tree/port-to-sdl2

(btw. #33 is also a thing)

from openjazz.

Dont worry about the late reply, it is a hobby after all.

I am surprised to see that other people tried to port to SDL2 and failed on the same point...
So, any ideas on what could we do about it? The very concept of "logical palette" sounds strange to me: 8bit paletted modes just have pixel values that point to a palette, and I dont understand anything more about it.
So, maybe we should somehow operate both palettes in video::expose() before calling SDL2 SetPaletteColors()? How?

from openjazz.

OpenJazzNX - i have ported OpenJazz to SDL2 and Nintendo switch , Sauce Soon ...
https://youtu.be/2AI8i5xkAIU

from openjazz.

https://github.com/KranKRival/OpenJazzNX SDL2 sause

from openjazz.

@vanfanel FWIW I cross referenced KranKRival's work and added it to a fork of the latest SC of OpenJazz and have it running fine with SDL2 without the Nintendo Switch specifics.

Whilst it's 80% clean, it does have the same issue with the bonus levels which are removed on this build as the libNX build. I can do a PR but It wouldn't be wise unless they created a new SDL2 branch upstream.

(huge thanks to KranKRival of course)

from openjazz.

@swingflip Great! Now if a new SDL2 branch could be created upstream... SDL1.x is not recommended at all in 2020.

from openjazz.

I think @carstene1ns is the latest active member, hopefully he reads this and creates a SDL2 branch which we can push a PR to and hopefully fix up.

from openjazz.

oh lets hope so indeed

from openjazz.

@carstene1ns Could you please create the SDL2 branch? This wonderful engine really needs to go SDL2.

from openjazz.

I am not going to push this in the current state. It is full of bad palette hacks, so needs serious cleanup.
I do not have the time currently to work on this, so nothing is going to happen soon.

from openjazz.