Giter VIP home page Giter VIP logo

Comments (5)

allen505 avatar allen505 commented on June 12, 2024

Hi @dnknn . This is a nice suggestion.
However I am not prioritizing this at the moment because there are a lot of features in the pipeline for the next version already. I'm also not entirely sure if a notification is required when a save is performed. Maybe we can add that as an option "Notify when a Save is made using shortcut : On/Off"
References:
Adding a keyboard shortcut for the extension
Adding a notification

from save-for-later.

dnknn avatar dnknn commented on June 12, 2024

I'm also not entirely sure if a notification is required when a save is performed.

Of course, no notification is required for the actions of users clicking with the mouse on Popup. Because the operation is directly visible!

But using hotkey is different.

  1. Save, obviously it is an important operation.
  2. If no notification, it will be silent. e.g. Press the wrong hotkey, e.g. it was not successfully saved, etc.
  3. Obviously, this kind of notification is just a perceptual reminder, so it will automatically disappear/close after a few seconds!

Therefore, this notification behavior is very reasonable and necessary, and will not burden the user (the notification will automatically close after a few seconds)

Maybe we can add that as an option "Notify when a Save is made using shortcut : On/Off"

it's up to you!

from save-for-later.

allen505 avatar allen505 commented on June 12, 2024

My reasoning is that notification will require an extra permission and is system generated AFAIK. I was thinking something like a small popup from the extension's button or a maybe a text overlay. Need to do a bit more research on notification before finalizing

from save-for-later.

dnknn avatar dnknn commented on June 12, 2024

@allen505

notification will require an extra permission

There is no problem at all, because notification itself is a very basic function. When you need it, you must have notification permissions. If you use enough extensions, you can obviously feel that many extensions have notifications, of course, the premise is they It does need to be notified.

212_20111147

I know what you mean, it's okay if you don't extension much, but if you extension a lot, do you think you can see it?

Even the extension icon is hidded, so your approach is useless.

So when using hotkeys to assist with notifications is the best way!

from save-for-later.

allen505 avatar allen505 commented on June 12, 2024

I see your point. I'll update here after a better research on implementation details

from save-for-later.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.