Comments (1)
From what has been communicated to me in discord, the plan is to encapsulate and refactor out the implementation within dolma to use this crate.
If this is correct, I'll try to bring the work here myself as well (a bit busy so cannot commit on any specifics more than that)
In the meantime I'll share how I approached and prepared the original PRs.
I tended to follow the hints from cargo clippy
and when everything was clear there, cargo clippy -- -Wclippy::pedantic
pedantic
can potentially lead to more false positives, but it is still useful to understand whether they are indeed false positives and why. If it is indeed spurious, we can document and allow the lints individually or crate wide.
I also tried to maximize refactoring and modularization, which for me is helpful to understand and lint against.
Some more semantic-syntactic changes I was looking for was investigating the relevant mathematic formula and Rust code, taking into detail how they match and differ. Making clear what was or could be done for code readability and performance was helpful.
Supporting all of this is of course more tests, and I think adding tests here in an organic manner could be the first step forward, both enhancing test coverage here and allowing for more dynamic and robust refactors and fixes.
from bff.
Related Issues (7)
- Code should use threads to run in parallel HOT 1
- Output to a file instead of stdout HOT 1
- Ngram instead of paragraph removal? HOT 1
- bff_duplicate_spans are index in bytes not characters
- Is the deduplication scope separate or global when deduplicating multiple files? HOT 1
- Modified BFF version mentioned in DataComp-LM paper
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bff.