Comments (7)
@xoxys 💯 that's fantastic! I've copied the test example into the canonical set of test clusters used in the test framework and will get a fix out shortly.
from flux-local.
Yes, can take a look. Do you have a pointer to an example repo that exhibits the problem?
from flux-local.
Thanks. I've created a min reproduction repo at https://github.com/xoxys/flux-local-test. Home that helps.
from flux-local.
Releasing in 2.0.0
from flux-local.
@allenporter Thanks again. The build
command works now but test
fails:
flux-local test --enable-helm --path ./flux -a "batch/v1/CronJob"
[...]
/usr/lib64/python3.11/asyncio/tasks.py:267:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = Command(cmd=['helm', 'template', 'renovate', 'flux-system-renovate/renovate', '--namespace', 'default', '--skip-crds',...w0269cv/repository-config.yaml'], cwd=None, exc=<class 'flux_local.exceptions.HelmException'>, retcodes=None, env=None)
stdin = None
async def run(self, stdin: bytes | None = None) -> bytes:
"""Run the command, returning stdout."""
_LOGGER.debug("Running command: %s", self)
env = {
**os.environ,
**(self.env if self.env else {}),
}
proc = await asyncio.create_subprocess_shell(
self.string,
stdin=subprocess.PIPE,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
cwd=self.cwd,
env=env,
)
out, err = await proc.communicate(stdin)
if proc.returncode:
if self.retcodes and proc.returncode in self.retcodes:
return out
errors = [f"Command '{self}' failed with return code {proc.returncode}"]
if out:
errors.append(out.decode("utf-8"))
if err:
errors.append(err.decode("utf-8"))
_LOGGER.error("\n".join(errors))
> raise self.exc("\n".join(errors))
E flux_local.exceptions.HelmException: Command '(None) helm template renovate flux-system-renovate/renovate --namespace default --skip-crds --skip-tests --values /tmp/tmphw0269cv/default-renovate-values.yaml --registry-config /dev/null --repository-cache /tmp/tmprd4jz592 --repository-config /tmp/tmphw0269cv/repository-config.yaml' failed with return code 1
E Error: execution error at (renovate/templates/cronjob.yaml:8:6):
E
E ERROR: You must have at least batch/v1beta1 to use CronJob
E
E Use --debug flag to render out invalid YAML
../../.local/pipx/venvs/flux-local/lib64/python3.11/site-packages/flux_local/command.py:87: HelmException
------------------------------------------------------------------------------------- Captured log call --------------------------------------------------------------------------------------
ERROR flux_local.command:command.py:86 Command '(None) helm template renovate flux-system-renovate/renovate --namespace default --skip-crds --skip-tests --values /tmp/tmphw0269cv/default-renovate-values.yaml --registry-config /dev/null --repository-cache /tmp/tmprd4jz592 --repository-config /tmp/tmphw0269cv/repository-config.yaml' failed with return code 1
Error: execution error at (renovate/templates/cronjob.yaml:8:6):
ERROR: You must have at least batch/v1beta1 to use CronJob
Use --debug flag to render out invalid YAML
================================================================================== short test summary info ===================================================================================
FAILED flux::kustomization::default/renovate - flux_local.exceptions.HelmException: Command '(None) helm template renovate flux-system-renovate/renovate --namespace default --skip-crds --skip-tests --values /tmp/tmphw0269cv/default-...
from flux-local.
Ok must have busted something during refactor
from flux-local.
Tagged 2.0.1 with a fix.
I've added the test repos to CI to make sure the tests are run in an additional way for every repo.
from flux-local.
Related Issues (20)
- bug: absolute paths aren't supported within flux kustomizations HOT 1
- Action Required: Fix Renovate Configuration
- Provide a way to parse out images from rendered manifests and Helm Releases HOT 7
- Cache pip in github action HOT 1
- Provide a way to output results (`--output-file`) to a file
- Running with relative path outside of git repo fails
- Move away from deprecated set-output commands in actions
- Required fields in Helm templates causes templating of helm charts to not work HOT 4
- Concurrency issues with flux build without kustomization.yaml HOT 8
- Failing to find HelmRepository HOT 13
- Validate dependsOn rules HOT 2
- Error when starting the application HOT 5
- Support GitRepository for HelmRelease sources HOT 17
- HelmRelease Error: template due to substituteFrom not being supported HOT 11
- Github actions diff - Argument list too long HOT 1
- Test does not work with OCI repositories HOT 4
- No diff when comparing two versions of helm charts HOT 4
- Error with diff in github actions HOT 2
- [v5.3.0] GitHub Actions fail to install requirements HOT 4
- User report: Replace: id matched 2 resources HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flux-local.