Zoom in / out not always working about allusion HOT 25 CLOSED

Usually, you only see it in the commits or if your IDE keeps screaming at you that something is wrong even though it passed continous integration on Github already but else not that I know of.

from allusion.

Running yarn install (or just yarn) will do that, if everything is up to date it'll tell you that

from allusion.

i think yarn install did it know. Thought i did that already earlier today.

Thanks again

from allusion.

When I open the menu it also shows that I need to press ctrl + shift + = to zoom in.

from allusion.

The solution is to change the shortcut in main.ts:

{ role: 'zoomin', accelerator: 'CmdOrCtrl+=' }

but then it shows it in the menu as ctrl + =. Furthermore, clicking the menu entry doesn't do anything. I will try to look whether I can add it manually.

from allusion.

Other people add two shortcuts for zooming in (for both + and =) but that looks a little weird.
An alternative would be to add the shortcuts in the HotKeys component, and then manually adjusting the webFrame.zoomFactor instead of letting electron handle the shortcuts

from allusion.

@RvanderLaan I'm adding manually the click functionality for zoom in/out and reset menu entries right now because it does not work. Leaving the shortcut to the HotKey component seems fine but I haven't fixed my shortcut issue with it (shift+/ on non-american keyboards). Alternatively, we register it ourselvers or add a button to the settings menu to show the hotkeys.

from allusion.

Hmm, for me the buttons in the Electron toolbar work fine unless I'm focused on the devtools

from allusion.

I tried the github release and packaged it myself but in both cases it does not zoom in/out or reset on clicking the menu entries in View. If I implement it myself, it does work.

from allusion.

Right, that's really weird, I didn't check the release version before. Nice that you found a workaround!

from allusion.

Im looking at the master and i get errors when packaging this master

from allusion.

Did you try yarn install before packaging? I've updated electron and the packager.

from allusion.

ill try that, thanks!

from allusion.

Is there something which can check if dependencies are up to date? I seem to have this issue now and then. I dont see it until i try to package and then get an error

from allusion.

Also awkward is that when i run yarn add electron i get version 5.0.0 but in the package.json it states dependencies "electron": "^6.0.1"?

from allusion.

Basically, you're installing the latest version of electron. You probably have now two electron versions in your node_modules.

from allusion.

You have any ideas why i know see errors with the menu items in main.ts I had so many issues again. Not sure why or what, updated a bunch of files and now i get these errors. While earlier it was working just fine??

from allusion.

Are you on master or another branch? This seems to be old code.

from allusion.

This is on master

from allusion.

Sorry this one is, but i get same error. The other one was i believe image-viewer-cssupdate.

from allusion.

Hmm, can you try yarn install on master branch? The only issue you could have is that it cannot recognize the role appMenu in the if statement for apple in line 35 because that is in a higher electron 5 release.

from allusion.

okay, i try if electron will update to 6 i wouldnt do that earlier. It would update/install but it was 5.0.8 ??

from allusion.

Ps i just checked electron and it is actually 6.0.1 i believe i installed it again with npm this time?
Its quite confussing again

from allusion.

I now did yarn install and then electron is 5.0.8???

from allusion.

What is written in you package.json? It should be 5.0.8. It could be that in your node_module folder contains two versions and those are conflicting but that shouldn't be the issue. Well, restarting vscode might help, otherwise delete node_modules folder and run yarn install.

from allusion.