Live specialist_document content item does not pass example validation about govuk-content-schemas HOT 8 CLOSED

@Looks like details.document_type was disallowed in the schema in 8212a1e.

Most likely scenario is that after making that change, not all documents were republished to publishing-api. You could try republishing on integration to confirm.

from govuk-content-schemas.

@tijmenb Coming back to this today, I wonder how we can stop this happening in the future. Maybe something that periodically tests random content items are valid? Probably a better way.

It's hard to be confident that published content is in a valid state.

from govuk-content-schemas.

Yep, I think that would be a good idea. Another option is to validate the output of the content-store.

@kevindew thoughts?

from govuk-content-schemas.

Yeah - to be absolutely confident the validating of content-store output sounds like a good idea. Quite destructive though, but that would give frontend applications a greater assurance.

I guess though if we go down the route we want assurances before a 500 error.

Naturally best thing would be immutable schemas, I guess complexity/cost of implementation rules that out

So other supplementary ideas could be:

• Forbidding at merging point updating a schema that is backwards incompatible with previous version (could always be forced with an admin merge for exceptional circumstances). To encourage new schemas for backwards incompatible changes.
• Storing a date when a schema is generated and a date in the Publishing API for when last validated to make it easier for Publishing API to be able to batch validate

from govuk-content-schemas.

Seeing a new issue when attempting to update examples to match live:

The property '#/links' contains additional properties ["finder"] outside of the schema when none are allowed in schema file:///var/govuk-sites/govuk-content-schemas/dist/formats/specialist_document/frontend/schema.json

This stops us from building features against the facets found in the finder item and testing them against examples.

cc @thomasleese @kevindew

from govuk-content-schemas.

@fofr started having a look into this yesterday - is a little painful but will prioritise it.

from govuk-content-schemas.

pretty sure this is done

from govuk-content-schemas.

Fix is here: #585

from govuk-content-schemas.