Comments (2)
Hi,
thanks for the feedback on this. This has cause me to do quite a lot more reading around this area, and I think the reason this hasn't been a problem for us is because we're running exclusively on x86/amd64 platforms.
Nevertheless, as this code is not guaranteed to be correct under the Go memory model, I've added a mutex to protect access to this pointer in #67. This seemed to be cleaner than going down the unsafe.Pointer
route.
from router.
Since the potential race condition mentioned is now prevented by #67 and there has been no further feedback, I'm going to close this issue.
Thanks for raising this @balasanjay! 👍
from router.
Related Issues (11)
- Bug: incoming URLs are decoded before being looked up
- All logging goes to error log HOT 1
- Incorrect backend_url value for Reading library on the search-library-catalogue route HOT 3
- Integration tests fail (in GOV.UK Docker) HOT 2
- Development is not possible using govuk-docker HOT 3
- Requests being routed to nonexistent backend `whitehall-frontend`. HOT 1
- Integration test setup flakes at `Waiting up to 20 s for for successful rs.initiate()`. HOT 1
- Integration tests fail to start up on GitHub Actions. HOT 4
- CodeQL check keeps breaking with "configuration not found"
- triemux: (*Mux).ServeHTTP could be sped up by hoisting out and compiling shouldRedirToLowercasePath's regular expression
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from router.