Giter VIP home page Giter VIP logo

Comments (2)

alext avatar alext commented on May 29, 2024

Hi,

thanks for the feedback on this. This has cause me to do quite a lot more reading around this area, and I think the reason this hasn't been a problem for us is because we're running exclusively on x86/amd64 platforms.

Nevertheless, as this code is not guaranteed to be correct under the Go memory model, I've added a mutex to protect access to this pointer in #67. This seemed to be cleaner than going down the unsafe.Pointer route.

from router.

mattbostock avatar mattbostock commented on May 29, 2024

Since the potential race condition mentioned is now prevented by #67 and there has been no further feedback, I'm going to close this issue.

Thanks for raising this @balasanjay! 👍

from router.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.