Comments (2)
ydnar
commented on September 1, 2024
2
Interesting. That would work similar to GoGo’s enum prefixing / naming extensions.
Currently, the generated Go enum value names can have stuttering type name + existing PREFIX_ (if specified to avoid clobbering values in generated C++).
I think this should be solved together.
from protopatch.
ydnar
commented on September 1, 2024
Hi there, now that stuttering prefixed names can be fixed with the lint option, and Go names for enum values can be specified directly, I’m going to close this. I don’t think it’s a good idea to have another API that duplicates already available functionality, even if it is verbose. A little duplication in Go is OK!
from protopatch.
Related Issues (13)
- Question: why so many proto imports? HOT 5
- Missing descriptor.proto in google/protobbuf
- lint initialisms missing "IDs" HOT 2
- please ignore
- Annotations in YML files HOT 3
- enums declared in messages are not patched
- use of external plugins breaks generated code HOT 14
- Support public imports HOT 2
- `option (go.lint).all = true;` does not work for enum values imported from other package HOT 1
- Proto3: add optional support HOT 1
- Multiple packages with the same "leaf" package name can cause go.lint options to be ignored.
- Gen enums error :--go-patch_out: protoc-gen-go-patch: Plugin failed with status code 1.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protopatch.