Giter VIP home page Giter VIP logo

Comments (4)

chrisketelaar avatar chrisketelaar commented on June 29, 2024 2

For me it would make sense to change "Unauthorized" to "Forbidden" because .net is handling authentication for me and authorization is done in layers where I use ErrorOr, but I can't say if that is the case for alle developer which use ErrorOr.

I think Unauthorized could still be useful for developers which roll there own authentication so maybe Forbidden could be added instead of replacing Unauthorized. Adding will also maintain backwards-compatibility.

from error-or.

amantinband avatar amantinband commented on June 29, 2024

Hey guys. I intended the "Unauthorized" to mean the user failed some authorization step (not authentication).

I understand why this is confusing given 401 is "Unauthorized" and not "Unauthenticated".

Perhaps "Forbidden" would have been a better name choice. I can rename "Unauthorized" to "Forbidden" if you think it is worth the change, but please note this would be a breaking change.

Let me know would you think.

from error-or.

bCamba avatar bCamba commented on June 29, 2024

I would also like this so I created a PR (I did not see there was already an open PR for this so I am happy with any merge)

from error-or.

amantinband avatar amantinband commented on June 29, 2024

added #86

from error-or.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.