Comments (4)
For me it would make sense to change "Unauthorized" to "Forbidden" because .net is handling authentication for me and authorization is done in layers where I use ErrorOr, but I can't say if that is the case for alle developer which use ErrorOr.
I think Unauthorized could still be useful for developers which roll there own authentication so maybe Forbidden could be added instead of replacing Unauthorized. Adding will also maintain backwards-compatibility.
from error-or.
Hey guys. I intended the "Unauthorized" to mean the user failed some authorization step (not authentication).
I understand why this is confusing given 401 is "Unauthorized" and not "Unauthenticated".
Perhaps "Forbidden" would have been a better name choice. I can rename "Unauthorized" to "Forbidden" if you think it is worth the change, but please note this would be a breaking change.
Let me know would you think.
from error-or.
I would also like this so I created a PR (I did not see there was already an open PR for this so I am happy with any merge)
from error-or.
added #86
from error-or.
Related Issues (20)
- ErrorOr type cannot be deserialized HOT 1
- Cannot implicitly convert type IQueryable<T> to ErrorOr.ErrorOr<IQueryable<T>> HOT 5
- Can't change response http status code HOT 2
- Add ability to show result and errors HOT 2
- ❌ ErrorType NotAuthorized
- How do I disable ErrorOr if I set my environment to development and only enable it when it is changed to Production?
- How can I create an Error type that has exception data? HOT 1
- Please add a strong name for the assembly HOT 1
- Errors: Count = 1; IsError: False HOT 1
- Non generic ErrorOr possible? HOT 3
- IsError = true; Errors.Length = 0; HOT 9
- Add Stacktrace property to the Error struct HOT 3
- Is there an ability to chain multiple validation methods returning ErrorOr<T>? HOT 14
- [Request] Please sign the NuGet with a strong name HOT 2
- [Bug] Error equality not working as intended HOT 4
- SUGGESTION: Add a changelog for each version released HOT 1
- erroror is missing NuGet package README file HOT 2
- Return ErrorOr<?> HOT 2
- [Request] Add overload without capturing errors or values in functional methods
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from error-or.