Comments (3)
ecoon
commented on August 22, 2024
Apparently the code was added and commented out in the same commit, many years ago.
Rarely is Q a function of p -- maybe only in the case of exchange fluxes/eg macropores?
But it should be fine to include, as the "IsDependency" should ensure it isn't called when it isn't needed...
from ats.
ecoon
commented on August 22, 2024
closed in #64
from ats.
ecoon
commented on August 22, 2024
It sure doesn't look like this was closed in that PR? It is the case that the source is rarely if ever dependent upon p, but still, a check to IsDifferentiableWRT() should be implemented.
from ats.
Related Issues (20)
- add evaluators for interpolation in time, use them in ats transport
- Running ATS in cluster promtps me with missing libraries HOT 2
- enforce negative depth for nonplanar faces
- Supersaturated water HOT 2
- Why the installation of ATS failed? HOT 4
- restarted observations with "integrated in time" are bad for the first observation HOT 1
- Add B&C WRM, allow magic omega rel perm model to use B&C lambda
- richards hydrostatic ICs use cell_centroid
- aspect incorrect in the upper left quadrant HOT 1
- ApplyInverse() return code
- Restore CI for new TPLs on david/amanzi-tpls-0.98.8 branch
- refactor transport HOT 1
- Misses by Input File Convertors HOT 2
- "restart from checkpoint file" not working HOT 1
- tests requiring geochemistry still run when compiling with --disable-geochemistry HOT 1
- Can ATS write output directly for ESSDIVE?
- elm_ats_driver still has boost dependencies HOT 2
- elm_ats_driver requires updates regarding Teuchos and Amanzi mesh refactor HOT 1
- issues extracting the groundwater discharge for Coal Creek
- Separate perched water table depth and water table depth
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ats.