Comments (9)
It looks like the following needs to be done:
There is a method in Amanzi::State called InitializeIOFlags_() (or something close) -- this method needs to be made public instead of protected.
Then, a call to that method should be added to ATS's coordinator in Initialize -- see State::Initialize() for where it fits in context to the other Initialize methods called there.
Looks like Daniil's previous commit shows where it should be.
from ats.
I made the method public yesterday in Amanzi, when I looked at the problem from Amanzi's angle, see the last commit.
from ats.
It seems Konstantin's updates are not sufficient to make this work for ATS.
I incorporated Konstantin's updates and added "S_->InitializeIOFlags_();" in the ATS's coordinator (I don't know why Danill's commit shows where it should be but does not exist in the latest commit anymore), but it still does not work immediately.
Is there anywhere else I need to add? I can help look into it more.
from ats.
InitializeIOFlags_() is better to be called after the PK and State were initialized. This is the only reasonable requirement I can think of. Also, this routine is a part of State::Initialize(); hence, there is no need to call it in all initialization algorithms.
from ats.
ATS doesn't call State::Initialize, because of the order issue. Instead it calls the components individually.
Agreed that it should get called after PK and the rest of the state initialization stuff though.
If it is public, it should lose the trailing underscore in Amanzi though.
from ats.
I can drop underscore and update both ATS and Amanzi now without a PR if you do not mind.
from ats.
from ats.
@lipnikov Just let you know that adding IO flags seems not sufficient to resolve this issue.
from ats.
I believe this issue has been fixed in the master.
from ats.
Related Issues (20)
- add evaluators for interpolation in time, use them in ats transport
- Running ATS in cluster promtps me with missing libraries HOT 2
- enforce negative depth for nonplanar faces
- Supersaturated water HOT 2
- Why the installation of ATS failed? HOT 4
- restarted observations with "integrated in time" are bad for the first observation HOT 1
- Add B&C WRM, allow magic omega rel perm model to use B&C lambda
- richards hydrostatic ICs use cell_centroid
- aspect incorrect in the upper left quadrant HOT 1
- ApplyInverse() return code
- Restore CI for new TPLs on david/amanzi-tpls-0.98.8 branch
- refactor transport HOT 1
- Misses by Input File Convertors HOT 2
- "restart from checkpoint file" not working HOT 1
- tests requiring geochemistry still run when compiling with --disable-geochemistry HOT 1
- Can ATS write output directly for ESSDIVE?
- elm_ats_driver still has boost dependencies HOT 2
- elm_ats_driver requires updates regarding Teuchos and Amanzi mesh refactor HOT 1
- issues extracting the groundwater discharge for Coal Creek
- Separate perched water table depth and water table depth
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ats.