Fix "blacklist" for NOT writing variables into visualization file about ats HOT 9 CLOSED

It looks like the following needs to be done:

There is a method in Amanzi::State called InitializeIOFlags_() (or something close) -- this method needs to be made public instead of protected.

Then, a call to that method should be added to ATS's coordinator in Initialize -- see State::Initialize() for where it fits in context to the other Initialize methods called there.

Looks like Daniil's previous commit shows where it should be.

from ats.

I made the method public yesterday in Amanzi, when I looked at the problem from Amanzi's angle, see the last commit.

from ats.

It seems Konstantin's updates are not sufficient to make this work for ATS.

I incorporated Konstantin's updates and added "S_->InitializeIOFlags_();" in the ATS's coordinator (I don't know why Danill's commit shows where it should be but does not exist in the latest commit anymore), but it still does not work immediately.

Is there anywhere else I need to add? I can help look into it more.

from ats.

InitializeIOFlags_() is better to be called after the PK and State were initialized. This is the only reasonable requirement I can think of. Also, this routine is a part of State::Initialize(); hence, there is no need to call it in all initialization algorithms.

from ats.

ATS doesn't call State::Initialize, because of the order issue. Instead it calls the components individually.

Agreed that it should get called after PK and the rest of the state initialization stuff though.

If it is public, it should lose the trailing underscore in Amanzi though.

from ats.

I can drop underscore and update both ATS and Amanzi now without a PR if you do not mind.

from ats.

from ats.

@lipnikov Just let you know that adding IO flags seems not sufficient to resolve this issue.

from ats.

I believe this issue has been fixed in the master.

from ats.