Giter VIP home page Giter VIP logo

Comments (3)

pmelab avatar pmelab commented on June 19, 2024

Hi Fredrik!

I'm sorry for the late response, but since this is heavily worked on and we didn't actively advertise it, I didn't expect anybody to jump on it 😄

The more I'm impressed that you were able to figure it out without any guidance or documentation!

In the last weeks we figured out how powerful custom web components are in this context, and the current plan is to eventually sunset the media and linkit packages and drastically slim the templates package down to pure document model management. All the UI heavy components (buttons, media previews, containers, tabs, galleries ...) become pure web components and therefore easier to maintain and compose.

After this "reduction" we probably also would upgrade ckeditor packages.

If you are interested in this project contact us on drupal slack! I would love to get some more opinions.

from ckeditor5_sections.

frega avatar frega commented on June 19, 2024

@pmelab - i've rerolled and incorporated the changes from the "great cleanup".
happy to open a PR against ckeditor5-template if you think it makes sense. The required changes are moderate (https://github.com/AmazeeLabs/ckeditor5-template/compare/master...frega:ckeditor5v12) but could probably benefit from a little coordinated refactoring.

To test this in context I suggest these steps to review:

  1. git clone [email protected]:frega/ckeditor5.git --branch ckeditor5v12 ; cd ckeditor5
  2. mgit sync # might require npm install -g mgit2
  3. yarn install
  4. Followed by yarn run manual opening http://localhost:8125/ckeditor5-build-drupal-sections/tests/manual/ckeditor.html
  5. yarn run test --files=template (drupal-media and drupal-linkit have been dropped)

from ckeditor5_sections.

pmelab avatar pmelab commented on June 19, 2024

Has already been merged some time ago. Thanks again 😄

from ckeditor5_sections.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.