ChatSession.onConnectionEstablished() is fired twice after invoking ChatSession.connect() about amazon-connect-chatjs HOT 3 CLOSED

The code fix does not fix the described issue of CHAT_EVENTS.CONNECTION_ESTABLISHED being fired twice. There is still an event fired from the connect call, and one from LpcConnectionHelper. Perhaps this is desired behavior, but that should be noted. As it stands, onConnectionEstablished is still called twice when connect is called a single time.

This is particularly interesting because when using amazon-connect-chat-interface, the duplicated call to onConnectionEstablished causes the transcript API to be called twice, which could seriously affect rate limits.

from amazon-connect-chatjs.

@sseidel16 You are correct. I believe this may have been the result of a mixup. Looks like PR #196 resolved #123 instead of this issue.

from amazon-connect-chatjs.

Another interesting note:

The proposed fix in the initial issue is likely not feasible because, when used in conjunction with streams, the websocket can be already connected when connect is called (wsm has already connected). In that scenario, onConnectionEstablished is only called by connect, and therefore only invoked once. It seems more reasonable to only emit a connection established event after connect if the websocket has already been started (this can be seen in the response from LpcConnectionHelper start).

from amazon-connect-chatjs.