Comments (1)
Мanual pre-deploy review was conducted (final at commit c72185b , with units tests at b8102d4) without any major issues reported. Automated security scanning/testing was performed using mythril & mythx which around the contract deployment time were the only Smart contract security tools supporting solc version 0.8.0+ . Several low severity issues were discovered mostly falling in the category "Solidity Coding Best Practices" which had been addressed/fixed. An attempt was made to downgrade the contracts to solc 0.6.12 and run a 'securfy' analysis, however results /report contained too many false positives because of the breaking changes in solc 0.8.0. (e.g. checking of all arithmetic by default). Post-deploy security scan was done running mythril at the addresses of the deployed contracts on mainnet without any major issues reported (the reported several low severity issues relating to the use of block.timestamp and multiple calls to own codebase executed in the same transaction are intended by design).
from adex-protocol-eth.
Related Issues (20)
- re-enable supplycontroller test HOT 1
- possible ADXToken improvements HOT 1
- submit audits to etherscan.io HOT 1
- Identity: add delegatecall abilities HOT 1
- add to snapshot.page
- Implement a test that simulates bulk withdrawal
- V5 contracts
- V5: StakingPool unlocking logic HOT 1
- Guardian: initiation fee
- Guardian: consider making an optional call to claim() every time HOT 1
- WalletZapper: trading/diversification helper for AdEx Wallet
- chore: migrate subgraph to their decentralized network
- Identity improvements related to the Wallet
- governance: implement voting with ADX-STAKING HOT 1
- Identity: v5.2: optimizations and SC signature support HOT 3
- chore: update to ethers v5
- fix CI HOT 1
- EIP1559 gas fee calculation in estimateNoRelayer (js/Bundle) HOT 1
- Security: chainId as part of signatures HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from adex-protocol-eth.