amcrawford / idea-box.js Goto Github PK

@rrgayhart

Hey! I didn't put this in my pull request but thought an issue might be an okay way to ask as well...

I have my thumb up and down functionality working so that you can click the icons, see the quality update without a page refresh and have the data save to the database but, the icon click does make the view jump back to the top of the page.

Here is a code-snippet of one of my methods that you can also find in ideas.js:

function likeIdea(id){
  $('#thumb-up' + id).on('click', function(){
    $.ajax($.getJSON('/api/v1/ideas/'+ id, function(idea){
      var newQuality = function(){
        if (idea.quality === 'swill'){
          return 'plausible'
        } else { return 'genius'}
      };
      $.ajax({
        type: 'PUT',
        url: '/api/v1/ideas/' + id + '.json',
        data: {
          idea: {quality: newQuality}
        },
        success: function(idea){
          $('#idea-quality' + id).html(newQuality);
        }
      })
    }))
  })
};

Let me know if you have any thoughts or if there it is better to stick to pull request communication as well!

Currently method is 25 lines long and handles screen manipulation, data fetching from fields and ajax call.