Giter VIP home page Giter VIP logo

Comments (5)

aritra-mukhopadhyay avatar aritra-mukhopadhyay commented on September 24, 2024

I came across a package which implements dynamic structure factor: https://dynasor.materialsmodeling.org/index.html
And the related paper: https://onlinelibrary.wiley.com/doi/10.1002/adts.202000240

from amep.

kai-luca avatar kai-luca commented on September 24, 2024

Thanks for the paper and the package. They do the dynamic structure factor really well.
Unfortunately they use their own trajectory format for all their calculations so I would have to look into that.
But I think we have two possibilities:

  1. We could just add dynasor as a dependency to amep and write wrappers around our their stuff.
  2. We could re-implement their algorithms and optimize them for our trajectories.
    In the spirit of open software my preferred way to do this would be proposal 1.
    As they are also a pure python library we would stay as platform independent as we are at the moment.
    We would gain dependencies on:

ASE and MDAnalysis are used for trajectory reading and might also help us with more compatibility to other simulation data formats.
pandas is used by them for data output. We already threw it out so it is really irrelevant.

On the other hand using their stuff and optimizing their upstream code for our use would improve both our and their code base.

from amep.

kai-luca avatar kai-luca commented on September 24, 2024

So now I need your opinions on what to do.

from amep.

aritra-mukhopadhyay avatar aritra-mukhopadhyay commented on September 24, 2024

I also think it's a better idea to implement proposal 1 after reading the advantages.

from amep.

kai-luca avatar kai-luca commented on September 24, 2024

So we talked it over. Since MDAnalysis is a full alternative data analysis framework we do not want it as a dependency.
Also we have half of the stuff dynasor implements already implemented in amep. So my plan now is to implement the stuff they did in dynasor in a similar way (and maybe try some optimizations).
If I manage to make some sensible optimizations I will also send them upstream to dynasor in the spirit of open software.

from amep.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.