Comments (7)
I think that would be a great idea. Unfortunately I've been really busy recently. I'd love contributions to add this :)
from eslint-plugin-flowtype-errors.
@jdmota Do you think you can look into this?
from eslint-plugin-flowtype-errors.
I can give it a shot if that's okay.
from eslint-plugin-flowtype-errors.
Of course!
from eslint-plugin-flowtype-errors.
I've started work on this feature this evening, but I do have a question. Should this just be handled like this or should this be opt-in or something?
Here are the options I'm thinking of.
- It just works as expected without any kind of modification to a user's eslint config.
- Warnings are ignored by default. In order to opt-in, you have to add a
flowtype-errors/show-warnings
rule to your eslint config. The advantage to this is that you could theoretically set warnings to appear as errors by setting this to2
/'error'
, or be ignored completely by setting it to0
/'off'
. The disadvantage is that it makes this all more confusing. I mean, if you wanted the warnings to display as errors, why wouldn't you just set the message in question towarn
in your.flowconfig
?
I don't have any strong personal preference. I'd lean towards option 2 just to give users the option. I don't presume to know or anticipate every user's bizarre workflow. I'd really appreciate your input, @amilajack, what with it being your repo and all. 😉
from eslint-plugin-flowtype-errors.
I'm almost done with an implementation of option 2 from above. I think that's the way to go since eslint reports things as errors or warnings based on the settings the user has given for the rule. That's probably the most straight-forward way of doing this without rocking the eslint boat.
from eslint-plugin-flowtype-errors.
Option 2 is a good idea. Also make sure to update the docs in the readme and the changelog
from eslint-plugin-flowtype-errors.
Related Issues (20)
- 32-bit error message is sometimes misleading HOT 2
- Broader flow-bin peer dependency range? HOT 2
- update flow-bin peer dependency
- Insufficient error information HOT 2
- Support latest version of Flow (0.66) HOT 5
- Feature request: a recommended shared config? HOT 2
- Cannot use 'JestMockFN' HOT 2
- No matching version found for [email protected] HOT 2
- Getting errors on TravisCI HOT 6
- Issue setting up monorepo HOT 7
- Tests against multiple eslint versions
- Error for typeof foo === 'symbol' HOT 1
- Hangs during webpack build HOT 2
- migrate from appveyor to azure pipelines
- How to configure this with create react app without ejecting ? HOT 3
- Error: Cannot resolve name `$Shape` (flowtype-errors/show-errors) HOT 5
- Action Required: Fix Renovate Configuration
- Dependency Dashboard
- deprecation warning appears on install
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-plugin-flowtype-errors.