[Feature Request] Option to Use Git Configured Editor as Default External Editor about tui-journal HOT 4 CLOSED

@AmmarAbouZor

Thanks for pointing out the access to the global configuration! I did only know about the local one, by now.

One thing that might be considerable is the ability to configure the preferred Git editor per repository. This is especially useful for users who contribute to multiple text editors. These users may have set their favourite editor in the global settings and altered their preferred editor per repository by configuring the respective editor the corresponding project is about. This use case should rather not be underestimated as there are plenty of text editors, especially in the Rust ecosystem where implementing them is very easy; furthermore, I experienced myself that contributors to text editors usually participate in the development of multiple editors (or at least switch to another project when one should become discontinued whilst still the setting regarding the Git editor for the discontinued project is reasonable as the maintainer might decide to work on their project, again).

However, this is a rather exotic edge case as most users cannot be expected to contribute to more than one editor, if any. So, it is up to you how you decide to take this scenario into account for the further development since the current implementation should fit for about 95% of the use cases, I guess.

from tui-journal.

For that scenario I think the best solution is to configure the editor from tui-journal configurations directly which gives the benefit of having the same experience using the app globally 👍

from tui-journal.

This could be useful for cross platform compatibility, since the current implementation has only UNIX in mind. I'll try to implement this and see how it would work

from tui-journal.

@kevinmatthes I've found the method git2::Config::open_default() which opens the git global the configurations.

I think it's more useful this way since the users most likely set the editor globally and this way we are not tied to the current directory.
If you think that there are other benefits from using the current directory please let me know

from tui-journal.