Comments (7)
This was the fix I have in place, but that will set Response.Range
to nil, which may possibly break client code.
// Read range
if string(tokens[2]) != "NA" {
if _, re.Range, err = net.ParseCIDR(string(tokens[2])); err != nil {
return
}
}
from ipisp.
Hmm.. How about setting it to 0.0.0.0/32
?
from ipisp.
Since it's unknown I think 0.0.0.0/0
makes more sense
from ipisp.
I think it would be safer for a consumer to assume that the ISP contains no IP ranges than every IP.
from ipisp.
0.0.0.0/0
is known as the default route, but I can see where you're coming from.
How about something like using the IP address as a /32
? For the above example 193.32.71.189/32
?
All of the solutions feel hokey, so I don't have a good answer.
from ipisp.
from ipisp.
Fixed in #15
from ipisp.
Related Issues (16)
- Lookup via DNS HOT 5
- "NA" ASNs cause panic HOT 2
- IPs returning multiple ASNs cuts off legitimate responses HOT 15
- publish official releases? HOT 1
- Inconsistent error between whois and dns for non existent record HOT 1
- v2
- Add connection persistence/timeouts HOT 1
- type ASN uint32
- parse asn error when there are multiple asn for a host HOT 1
- `go get -v github.com/ammario/ipisp/v2` fails while `go get -v github.com/ammario/ipisp` succeeds HOT 1
- Release v2.0.1 HOT 2
- Allow providing a custom DNS resolver HOT 1
- Error parsing multiple ASNs from reverse lookup HOT 2
- ASN Name Returns Bad Value HOT 3
- Bug in IPv4 Parsing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ipisp.