Giter VIP home page Giter VIP logo

Comments (7)

dacamp avatar dacamp commented on June 22, 2024

This was the fix I have in place, but that will set Response.Range to nil, which may possibly break client code.

// Read range
if string(tokens[2]) != "NA" {
        if _, re.Range, err = net.ParseCIDR(string(tokens[2])); err != nil {
        return
        }
}

from ipisp.

ammario avatar ammario commented on June 22, 2024

Hmm.. How about setting it to 0.0.0.0/32?

from ipisp.

dacamp avatar dacamp commented on June 22, 2024

Since it's unknown I think 0.0.0.0/0 makes more sense

from ipisp.

ammario avatar ammario commented on June 22, 2024

I think it would be safer for a consumer to assume that the ISP contains no IP ranges than every IP.

from ipisp.

dacamp avatar dacamp commented on June 22, 2024

0.0.0.0/0 is known as the default route, but I can see where you're coming from.

How about something like using the IP address as a /32? For the above example 193.32.71.189/32?

All of the solutions feel hokey, so I don't have a good answer.

from ipisp.

ammario avatar ammario commented on June 22, 2024

from ipisp.

ammario avatar ammario commented on June 22, 2024

Fixed in #15

from ipisp.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.