Giter VIP home page Giter VIP logo

Comments (9)

dkupnicki avatar dkupnicki commented on July 24, 2024 1

Ok, I got F1 = 0.601 when I changed the max_new_tokens from 10 to 100, which is understandable considering how this is calculated.

The best performance I got is 5.03.

from ampere_model_library.

jan-grzybek-ampere avatar jan-grzybek-ampere commented on July 24, 2024

Oh, and accuracy values I've provided were gathered with --num_runs=5.

from ampere_model_library.

kkontny avatar kkontny commented on July 24, 2024

Which transformers branch are we using for this? Here:
https://github.com/AmpereComputingAI/transformers/commits/karol/llama-compile-v2
the only change from original repo is to remove some validation checks which fail with Pytorch 2.1.

from ampere_model_library.

jan-grzybek-ampere avatar jan-grzybek-ampere commented on July 24, 2024

that's what we use - somehow it's very slow vs latest upstream - maybe they've introduced some significant improvements since our branching out? @dkupnicki please check when possible

from ampere_model_library.

kkontny avatar kkontny commented on July 24, 2024

Ok, you are comparing vs latest upstream. I think we may just rebase my branch on it. I see there was some work going over there, but didn't expect such difference. If AIO is generating same graph we can safely switch to newer implementation. Also numbers you are much lower than what I observed. Which version of pytorch-AIO and native pytorch have you used for this benchmarks? How long sequences are you generating.

I was having around ~9 tps in FP16 mode and around 5 tps in FP32 mode with AIO.

from ampere_model_library.

dkupnicki avatar dkupnicki commented on July 24, 2024

I can’t reproduce this issue. I tried with different versions of transformers, with and without AIO, with and without torch.compile() and I’m always getting the same 0.313 result.

from ampere_model_library.

jan-grzybek-ampere avatar jan-grzybek-ampere commented on July 24, 2024

Ok, I will check. What about performance? Can you get to 9 tps?

from ampere_model_library.

dkupnicki avatar dkupnicki commented on July 24, 2024

It was fp32 BTW, checking fp16 now

from ampere_model_library.

jan-grzybek-ampere avatar jan-grzybek-ampere commented on July 24, 2024

I guess we've solved that one. Closing. Thanks to you Daniel and Karol for your input.

from ampere_model_library.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.