Giter VIP home page Giter VIP logo

Comments (7)

bwoebi avatar bwoebi commented on May 18, 2024

Amp\Future is meant to be used inside libraries, i.e. it never should cross public API boundaries, correct.

from amp.

kelunik avatar kelunik commented on May 18, 2024

Why do we have it now? Why not just Deferred as we had previously?

from amp.

bwoebi avatar bwoebi commented on May 18, 2024

I'm not 100% sure why it's necessary. The only difference is it saving us from a single ->getAwaitable() call. I do not think this is worth it…

But perhaps I'm missing something and @trowski can tell.

from amp.

kelunik avatar kelunik commented on May 18, 2024

That's exactly why this issue exists.

from amp.

trowski avatar trowski commented on May 18, 2024

Future (and Producer for observables) only exists to avoid the function call to retrieve the awaitable (or observable) when the object will never be exposed to a public API. It's a minor performance bump, but if the confusion isn't worth it, Deferred and Postponed can be used instead.

from amp.

kelunik avatar kelunik commented on May 18, 2024

We didn't need it in Amp v1, I don't think we need it in Amp v2. It adds more confusion than a single method call can save us.

from amp.

bwoebi avatar bwoebi commented on May 18, 2024

Resolved by removal.

from amp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.