Giter VIP home page Giter VIP logo

Comments (7)

Danack avatar Danack commented on August 25, 2024 1

If someone explicitly sets the config, then it shouldn't do the fallback; it should behave exactly as they set the config.

If someone doesn't explicitly set the config, then people just want it to work and so the code should do the best attempt to work.

I don't like sending all DNS queries silently as a fallback to Google.

I trust with my DNS lookups (aka think they are less likely to snoop the data) than I do my ISP, that is far more likely to be in cahoots with GCHQ or other industrial espionage.

from dns.

kelunik avatar kelunik commented on August 25, 2024

We could also factor it out to a WindowsConfigReader, BindConfigReader and fallback to a EnvConfigReader that reads from a environment variable. This ensures you can always set the DNS nameserver in any application in case your system is weird.

We could also prioritize the environment variable / use it as fallback without the above.

from dns.

bwoebi avatar bwoebi commented on August 25, 2024

There's no point in factoring that out...

Also env variables, if we support them, should take priority in any case.

from dns.

kelunik avatar kelunik commented on August 25, 2024

There's no point in factoring that out...

Accept if you want to fetch the information from another source, but that's not required I guess.

from dns.

kelunik avatar kelunik commented on August 25, 2024

The man page mentions environment variables for options and local domain, but not for nameservers. http://man7.org/linux/man-pages/man5/resolv.conf.5.html

from dns.

kelunik avatar kelunik commented on August 25, 2024

Related: https://twitter.com/fudoreaper/status/873926204046405632

from dns.

kelunik avatar kelunik commented on August 25, 2024

The Google fallback has been removed in the Amp v2 version.

from dns.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.