Comments (7)
If someone explicitly sets the config, then it shouldn't do the fallback; it should behave exactly as they set the config.
If someone doesn't explicitly set the config, then people just want it to work and so the code should do the best attempt to work.
I don't like sending all DNS queries silently as a fallback to Google.
I trust with my DNS lookups (aka think they are less likely to snoop the data) than I do my ISP, that is far more likely to be in cahoots with GCHQ or other industrial espionage.
from dns.
We could also factor it out to a WindowsConfigReader
, BindConfigReader
and fallback to a EnvConfigReader
that reads from a environment variable. This ensures you can always set the DNS nameserver in any application in case your system is weird.
We could also prioritize the environment variable / use it as fallback without the above.
from dns.
There's no point in factoring that out...
Also env variables, if we support them, should take priority in any case.
from dns.
There's no point in factoring that out...
Accept if you want to fetch the information from another source, but that's not required I guess.
from dns.
The man page mentions environment variables for options and local domain, but not for nameservers. http://man7.org/linux/man-pages/man5/resolv.conf.5.html
from dns.
Related: https://twitter.com/fudoreaper/status/873926204046405632
from dns.
The Google fallback has been removed in the Amp v2 version.
from dns.
Related Issues (20)
- Too many time to resolve localhost domain HOT 7
- getting could not load the system's DNS configuration, using synchronous, blocking fallback error HOT 9
- Incomplete packet error (still exists) HOT 1
- Could Not Resolve Host HOT 3
- Backport queue errors on closure
- Rename Record and Resolver as well?
- Amp\Dns\resolve misses optional Cancellation parameter
- Async example? HOT 1
- Resolution where NDots > 1 failing
- Remove amphp/file dependency
- Bump the minimum version of amphp/uri HOT 4
- DNS resolution not working on Kubernetes HOT 5
- Subtype 'Too many redirects' DnsException HOT 1
- CreateProcess failed, error 193 HOT 6
- Libdns bug HOT 5
- Are dotless domains valid? HOT 3
- DNS frequently fails on Windows HOT 3
- Incomplete packet error HOT 4
- etc/resolve ndots set to 1 HOT 1
- Ignore ServFail / NxDomain for search list, e.g. in Kubernetes cluster HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dns.