Nicer handling of PTR queries about dns HOT 6 CLOSED

You should use Amp\Dns\query for everything that doesn't resolve to an IP address. So in this case yield Amp\Dns\query('8.8.8.8.in-addr.arpa', Amp\Dns\Record::PTR); But you're right, we could add auto-rewrite here.

@bwoebi Didn't we have a protection that restricts resolve to A and AAAA queries?

from dns.

Amp\Dns\resolve actually seems to work properly, Amp\Dns\resolve('29.56.141.209.in-addr.arpa', ['types' => Amp\Dns\Record::PTR]) gives me the right result.

from dns.

Yes, I know that it works, but it's not supposed to work. I think we had a restriction in there before.

from dns.

Do you have any suggestion for a better function name? I'm not sure what to do with an invalid IP, probably throw an exception, but not sure which one. InvalidAddressException might make sense, but it should probably not extend the ResolutionException in this case.

function ip2arpa($ip) {
    $packedIp = inet_pton($ip);

    if ($packedIp === false) {
        return null; // FIXME
    }

    if (isset($packedIp[5])) { // IPv6
        return wordwrap(strrev(bin2hex($packedIp)), 1, ".", true) . ".ip6.arpa";
    }

    return inet_ntop(strrev($packedIp)) . ".in-addr.arpa";
}

from dns.

I created a PR now. It doesn't use a separate function, see #52.

from dns.

It's now included in https://github.com/amphp/dns/releases/tag/v0.8.14.

from dns.