Comments (3)
Yes, this is result of https://core.trac.wordpress.org/ticket/58775
We'll need to fix by the time WordPress 6.4 is released.
As for the fix, the code in question is:
amp-wp/includes/class-amp-theme-support.php
Lines 1228 to 1241 in 2c4df9e
I believe it can be rewritten as follows, or something like it:
if ( ! function_exists( 'wp_enqueue_admin_bar_header_styles' ) ) {
remove_action( 'wp_head', $header_callback );
}
if ( '__return_false' !== $header_callback ) {
if ( ! function_exists( 'wp_enqueue_admin_bar_header_styles' ) ) {
ob_start();
$header_callback();
$style = ob_get_clean();
$data = trim( preg_replace( '#<style[^>]*>(.*)</style>#is', '$1', $style ) ); // See wp_add_inline_style().
} else {
$data = '';
}
// Override AMP's position:relative on the body for the sake of the AMP viewer, which is not relevant an an Admin Bar context.
if ( amp_is_dev_mode() ) {
$data .= 'html:not(#_) > body { position:unset !important; }';
}
wp_add_inline_style( 'admin-bar', $data );
}
from amp-wp.
from amp-wp.
QA Passed ✅
Cross-verified the issue and the applied solution is functioning correctly. Now, the deprecation warning related to the _admin_bar_bump_cb
is not visible.
Before | After |
---|---|
![]() |
![]() |
from amp-wp.
Related Issues (20)
- Omit page caching and object caching tests for Site Health if on WP>=6.1 HOT 7
- Update `AMP_Core_Block_Handler` to handle interactivity API enabled blocks HOT 1
- Lightbox images ("Expand on click") in WordPress 6.4 is broken on AMP pages HOT 1
- Search block with "button only" configuration is broken
- The attribute 'fetchpriority' may not appear in tag 'img' HOT 3
- Feature: Adding contributors section to the README.md file. HOT 3
- Breaks image and media blocks with Gutenberg 17.3.0 and 17.4.0 HOT 3
- Update node to v20 HOT 1
- Featured image not getting shown on WhatsApp. HOT 1
- Provide means to add CSP `nonce` attributes to AMP component script tags HOT 4
- Update PHP-CSS-Parser to v8.5.0 HOT 2
- Gutenberg's validation issues with Script Modules HOT 3
- Need a wordpress hook to change the form submit-success and submit-error element templates html content before rendered. HOT 4
- AMP error: Call to a member function hasAttribute() on null (0) [Error] HOT 2
- Script output for preview is not being marked as dev mode creating validation error HOT 2
- AMP error if admin bar styles are removed HOT 3
- Remove extraneous tags from readme HOT 2
- Incorrect use of $query->get_posts(), resulting in double request processing HOT 5
- Deprecation error with PHP 8.2 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from amp-wp.