Giter VIP home page Giter VIP logo

Comments (3)

cremno avatar cremno commented on August 20, 2024

mkxp uses the single-precision floating-point format for this and similar attributes while RGSS uses double-precision.

However even if it would be changed to double-precision you would still be able to find differences in very few cases. 1.8.1 is ancient and the code to convert between floating-point numbers and strings contained some bugs.

from mkxp.

khiav223577 avatar khiav223577 commented on August 20, 2024

Maybe a wrapper class is one possible solution?

  1. Rename the Sprite class implemented by mkxp as MkxpSprite
  2. Define new Sprite class that inherits from MkxpSprite
  3. Override zoom_x and zoom_x= method.
class Sprite < MkxpSprite
  attr_reader :zoom_x

  def zoom_x=(val)
    @zoom_x = val
    super
  end
end

It will be nice if mkxp can implement it. Make mkxp behave more consistent with original engine.


The following is a surprising behavior I found in current implementation:

# let (xxxxx / yyyyy.to_f) to be 0.9
sprite.zoom_x = xxxxx / yyyyy.to_f 

# ...
# ...

# sprite.zoom_x is 0.8999 here and fail to enter the if-condition since 0.8999 is not larger than or equals to 0.9
if sprite.zoom_x >= 0.9 
  #  ...
  #  ...
end

from mkxp.

Ancurio avatar Ancurio commented on August 20, 2024

I am curious what exact in-game issues this inaccuracy is causing.

from mkxp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.