Comments (6)
My Pascal is a little rusty but don't we need it so .InputString works as property?
from tregexpr.
Property will work anyway, it will be declared as
Property InputString: ..... read fInputString write SetInputString
Here getter GetInputString replaced with var fInputString, so user donβt call checks in GetInputString (which shows exception in it).
from tregexpr.
ups silly me..
of cause we do not need this getter if there are no checks..
from tregexpr.
This getter has one check, do we need it?
function TRegExpr.GetInputString : RegExprString;
begin
if fInputString = '' then begin
Error (reeGetInputStringWithoutInputString);
EXIT;
end;
Result := fInputString;
end; { of function TRegExpr.GetInputString
from tregexpr.
I think is my mistake - I better use the property inside TRegExpr so to return clear error message if a library user call something that use input string but forget to assign it first..
But I forget to use the property and use inside TRegExpr just fInternalString so that just does not work
from tregexpr.
Ok, I will remove the getter (after you apply my patch)
from tregexpr.
Related Issues (20)
- Crash with O4 HOT 3
- $DEFINE UnicodeRE off-> tests fail HOT 9
- function regNextQuick(p: PRegExprChar): PRegExprChar has problem with inline in delphi HOT 12
- Sub-call broken in loop HOT 2
- op-star prevents match HOT 5
- Delphi 12 changes HOT 2
- OP_Star / FindRepeated and group ref \1 HOT 3
- FindRepeatead and Unicode / may break OP_STAR/PLUS/... HOT 2
- OP_ANYLINEBREAK incomplete in FindRepeated
- OP_ANYLINEBREAK and FillFirstCharSet
- Optional Feature: backtracking is sub-calls HOT 5
- Nested back-ref does not work HOT 2
- Problems with DefParam and OverMeth defines in Delphi 12. HOT 6
- Add to CI matrix additional lazarus versions we want to support with
- Capture in CI benchmark and build report
- Add to CI runners to check `solaris x64` and `aarch64`
- Add to README badges with CI results
- Why test `TestBranches` takes so long? HOT 2
- Can we remove travis configs? HOT 1
- Crash when searching inside huge line (len=130K) HOT 20
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tregexpr.