Giter VIP home page Giter VIP logo

Comments (6)

andgineer avatar andgineer commented on August 16, 2024

My Pascal is a little rusty but don't we need it so .InputString works as property?

from tregexpr.

Alexey-T avatar Alexey-T commented on August 16, 2024

Property will work anyway, it will be declared as

Property InputString: ..... read fInputString write SetInputString

Here getter GetInputString replaced with var fInputString, so user don’t call checks in GetInputString (which shows exception in it).

from tregexpr.

andgineer avatar andgineer commented on August 16, 2024

ups silly me..
of cause we do not need this getter if there are no checks..

from tregexpr.

Alexey-T avatar Alexey-T commented on August 16, 2024

This getter has one check, do we need it?

function TRegExpr.GetInputString : RegExprString;
 begin
  if fInputString = '' then begin
    Error (reeGetInputStringWithoutInputString);
    EXIT;
   end;
  Result := fInputString;
 end; { of function TRegExpr.GetInputString

from tregexpr.

andgineer avatar andgineer commented on August 16, 2024

I think is my mistake - I better use the property inside TRegExpr so to return clear error message if a library user call something that use input string but forget to assign it first..
But I forget to use the property and use inside TRegExpr just fInternalString so that just does not work

from tregexpr.

Alexey-T avatar Alexey-T commented on August 16, 2024

Ok, I will remove the getter (after you apply my patch)

from tregexpr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.