Comments (9)
@Alexey-T could you fix that? and add tests for re like '[[ab]', '[]ab]'?
from tregexpr.
Will try it
from tregexpr.
Line 1010 is in the func RegExprSubExpressions, so the issue is in this func? Or it’s everywhere? Repro steps?
from tregexpr.
It checks for “]” as first char inside [] and in this case includes it into the char set.
But also it have to check also for “[” so we can use re “[[ab]*” to find string like “a[b”
To chech that we need tests with re like “[[ab]” and “[]ab]”
from tregexpr.
May be I found wrong line - it shoud be inside re parser
from tregexpr.
What wrong line, sorry ?
from tregexpr.
Line 1010
As I see it should be
Line 2807 in 61701cb
but we have to support this syntax in RegExprSubExpressions too
from tregexpr.
Pull request, with test 38
from tregexpr.
silly me - we do not need to check for '[' because user class ("[]") includes just any char but ']'.
so we should check only for ']' at first position.
from tregexpr.
Related Issues (20)
- Crash with O4 HOT 3
- $DEFINE UnicodeRE off-> tests fail HOT 9
- function regNextQuick(p: PRegExprChar): PRegExprChar has problem with inline in delphi HOT 12
- Sub-call broken in loop HOT 2
- op-star prevents match HOT 5
- Delphi 12 changes HOT 2
- OP_Star / FindRepeated and group ref \1 HOT 3
- FindRepeatead and Unicode / may break OP_STAR/PLUS/... HOT 2
- OP_ANYLINEBREAK incomplete in FindRepeated
- OP_ANYLINEBREAK and FillFirstCharSet
- Optional Feature: backtracking is sub-calls HOT 5
- Nested back-ref does not work HOT 2
- Problems with DefParam and OverMeth defines in Delphi 12. HOT 6
- Add to CI matrix additional lazarus versions we want to support with
- Capture in CI benchmark and build report
- Add to CI runners to check `solaris x64` and `aarch64`
- Add to README badges with CI results
- Why test `TestBranches` takes so long? HOT 2
- Can we remove travis configs? HOT 1
- Crash when searching inside huge line (len=130K) HOT 20
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tregexpr.