Comments (4)
andikleen
commented on June 26, 2024
What does this fix?
from pmu-tools.
ohm314
commented on June 26, 2024
This fixes the case when ocperf is used programmatically and the value for -c is given as the next item in the list rather than in the same string as -c
from pmu-tools.
andikleen
commented on June 26, 2024
Hmm, but getarg neither has a argv argument, nor does it reference argv (without sys). Are you sure there are no other changes in your tree?
https://github.com/andikleen/pmu-tools/blob/master/ocperf.py#L748
In fact it surprises me that the interpreter doesn't complain for passing this undeclared argument.
Also if it was changed the other callers probably would need to be changed too
from pmu-tools.
ohm314
commented on June 26, 2024
Yes, you are right of course. I see now that my branch is quite a bit ahead of your master. Let me bundle up the changes into one nice pull request and explain properly and then we can discuss.
Sorry, I was a bit too quick this morning...
from pmu-tools.
Related Issues (20)
- toplev: Info_Bottlenecks reports negative Scaled_Slots on SKX HOT 4
- toplev: Add option to only show bottleneck HOT 2
- toplev: Fix misaligned values in columns when area is too long
- tl-tester sometimes has comparison failures
- toplev does not print multiplex information for all metrics
- toplev: Compute minimum column widths for numbers / units
- toplev should print % for Scaled_Slots
- toplev should support filtering metrics by their threshold HOT 1
- ADL 100% Machine_Clears
- toplev should accumulate and report running time
- Add support for Meteor Lake HOT 1
- Test suite should cover both models for hybrid targets HOT 1
- toplev --run-sample: A requested CPU in '0' is not supported by PMU 'cpu_atom' (CPUs 8-23) for event 'cycles:pp' HOT 3
- toplev add option to only collect bottlenecks, not L1/L2
- MTL support misses Info.Bottlenecks HOT 1
- Trunk version of toplev regressed in generation of valid groups HOT 1
- CLTRAMP3D workload is not available
- Incorrect event for IpCall metric
- event_download returns incorrect list name in hybrid
- How to measure only the second part (a region) of a program? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pmu-tools.