ocperf.py event naming doesn't correspond to perf's one about pmu-tools HOT 4 CLOSED

With this change, will events specified with dot still work? It doesn't look like it because you replace the name mapping. Should be fine to allow specifying events with underscores, but doted events still need to work. So it would need two entries in the events hash for each event: one with dots, and another with underscores.

BTW not clear what problem this solves? You want to pass events from perf evlist back to ocperf?

from pmu-tools.

Ok it looks like your second patch does just that. Added thanks.

from pmu-tools.

Events with dots will work properly. In my pull-request I added new dictionary for perf-style named events ('perf_events' field) and added one more 'elif' statement to 'getevent' method:

I try to use ocperf.py with JMH (java microbenchmarking framework). JMH is able to run perf (or any other executable if I overwrite environment variable) and parser it's result. JMH memorizes event names which I specified in parameters (I should specify names with dots because these names will be passed to ocperf.py). During perf/ocperf.py output parsing JMH become a bit confused since there is not parameter names I specified (because underlying perf outputs names with underscored only).
Anyway, I believe it's a bit confusing: ocperf.py outputs (right, perf outputs) event names which differ from event names I passed as argument.

BTW, may be it's better to remove '.replace(".", "_")' from Event.output_newstyle method?

from pmu-tools.

from pmu-tools.