Giter VIP home page Giter VIP logo

Comments (11)

AndyScherzinger avatar AndyScherzinger commented on June 11, 2024

@willlunniss already did a pull request with the action bar but that doesn't matter, since we use the language files. So changing them will fix the lowercase in the action bar :)

from andlytics.

willlunniss avatar willlunniss commented on June 11, 2024

You didn't really answer the question - Should all the text be moved to sentense case where applicable: Yes/No?

from andlytics.

AndyScherzinger avatar AndyScherzinger commented on June 11, 2024

Well, like people mentioned before, things should be decided by the community.

Imho YES since it should be sentence case + it looks weird with the lowercase headings...

from andlytics.

willlunniss avatar willlunniss commented on June 11, 2024

OK should have said, do you think all the text should be...

I've just had a look through and it is straight forward except the bits such as comments that are used for X comments and as a title will have to be duplicated, other than that it is a simple update.

The bigger problem is the translations. The manual way which is probably quicker is:

  1. Make sure everything on getLocalization is in the git
  2. Remove any untranslated strings from the translations added by getLocalization
  3. Fix english and all the translations (note there may be a few langue errors which can be corrected later)
  4. Push english to getLocalization
  5. Login as the admin to getLocalization, go to the Files tab and one by one click on a language, select update, and pick the fixed translation file

The other option is mark strings as not needing to be re-translated in getLocalization when you import the new english version, and then go through using the editor fixing them. If you do mark them as needing translation, then you end up doing more copy and pasting.

Based on previous experience, I would recommend the first one, but would need your help with it.

from andlytics.

AndyScherzinger avatar AndyScherzinger commented on June 11, 2024

@willlunniss sounds fine, what do you need me to do then? Put actual files from getLocalization on github?

Other way: Change english version (will be updates on getLocalization via github), then update all others on getLocalization, fix capitalisation, export, push to github manually / pull request

from andlytics.

willlunniss avatar willlunniss commented on June 11, 2024

Ok, I'll give it a day to give people a chance to object to the change.

Just make sure any new translations are in github.com. Then once I've done it, upload the translations to getLocalization to override the lower case ones.

Sent via Hubroid

from andlytics.

fda77 avatar fda77 commented on June 11, 2024

I thin synchronisation getLocalization <-> github for english is not working, see th missing import/export strings!
I speak german, so the up-/lowcase things should somone do who knows it :)

from andlytics.

AndyScherzinger avatar AndyScherzinger commented on June 11, 2024

I'll have a look, maybe I'll find time for it tomorrow. Busy week at work...

from andlytics.

AndyScherzinger avatar AndyScherzinger commented on June 11, 2024

I would then put the getLocalization file on github and ping this thread when I am done.

from andlytics.

willlunniss avatar willlunniss commented on June 11, 2024

Ok so I have a commit, but sent the pull request to myself, any tips.... :(

from andlytics.

willlunniss avatar willlunniss commented on June 11, 2024

Ah this might be working now #90

from andlytics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.